Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #32910: Support enabling content caching for Pulp #372

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Fixes #32910: Support enabling content caching for Pulp #372

merged 1 commit into from
Jul 8, 2021

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jul 7, 2021

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2021

I figured exposing these was the cleanest way rather than relying on users configuring hiera.

ekohl
ekohl requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you raise the minimum version in metadata.json?

@ehelms ehelms requested a review from ekohl July 8, 2021 13:12
@ehelms
Copy link
Member Author

ehelms commented Jul 8, 2021

Updated

@ehelms ehelms mentioned this pull request Jul 8, 2021
Merged
@ehelms ehelms merged commit dee50ae into theforeman:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @ekohl @theforeman-bot