-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #32910: Add ability to enable content caching #204
Conversation
There is one other setting that is being discussed on how it should be exposed: https://github.com/pulp/pulpcore/pull/1356/files#r660160352 I have not included it for now as my read is that it should not be user facing. |
I have updated this to reflect the merged patch to Pulpcore that will be in 3.14. |
9c002c8
to
878394f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small clarification on the test part, other than that 👍
Adds a flag to enable content caching via Redis. This is disabled by default as its a new optional feature in Pulp 3.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbclark want to have a last look as well?
Adds a flag to enable content caching via Redis. This is disabled
by default as its a new optional feature in Pulp 3.14.
Requires pulp/pulpcore#1356 being present which is targeted for Pulpcore 3.14. This also updates the README to reflect that minimum version.