Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #32910: Add ability to enable content caching #204

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jun 29, 2021

Adds a flag to enable content caching via Redis. This is disabled
by default as its a new optional feature in Pulp 3.14.

Requires pulp/pulpcore#1356 being present which is targeted for Pulpcore 3.14. This also updates the README to reflect that minimum version.

@ehelms
Copy link
Member Author

ehelms commented Jun 29, 2021

There is one other setting that is being discussed on how it should be exposed: https://github.com/pulp/pulpcore/pull/1356/files#r660160352

I have not included it for now as my read is that it should not be user facing.

manifests/init.pp Outdated Show resolved Hide resolved
@ehelms
Copy link
Member Author

ehelms commented Jul 1, 2021

I have updated this to reflect the merged patch to Pulpcore that will be in 3.14.

README.md Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
@ehelms ehelms marked this pull request as ready for review July 2, 2021 12:54
spec/acceptance/basic_spec.rb Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the refs-32910 branch 2 times, most recently from 9c002c8 to 878394f Compare July 2, 2021 13:13
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise 👍

spec/acceptance/basic_spec.rb Show resolved Hide resolved
@ehelms ehelms requested review from wbclark and ekohl July 2, 2021 15:56
templates/settings.py.erb Outdated Show resolved Hide resolved
manifests/init.pp Outdated Show resolved Hide resolved
spec/acceptance/basic_spec.rb Outdated Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small clarification on the test part, other than that 👍

spec/acceptance/basic_spec.rb Outdated Show resolved Hide resolved
Adds a flag to enable content caching via Redis. This is disabled
by default as its a new optional feature in Pulp 3.14.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbclark want to have a last look as well?

@ekohl ekohl added the Enhancement New feature or request label Jul 7, 2021
@ehelms ehelms merged commit 401869c into theforeman:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants