Refs #35005 - use foreman client certs for pulp-cli auth #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
pulp-cli-cert
branch
5 times, most recently
from
7e8676b to
e1a59a1
Compare
evgeni
commented
Jun 14, 2022
evgeni
changed the title
evgeni
commented
Jun 14, 2022
ekohl
reviewed
Jun 14, 2022
| @@ -10,5 +10,8 @@ spec/spec_helper.rb: | |||
| - name: root_home | |||
| value: /root | |||
| source: puppetlabs-stdlib | |||
| - name: service_provider | |||
There was a problem hiding this comment.
It was my intention to move to add_mocked_facts! (from voxpupuli-test) but haven't gotten around to it. We should implement this in our modulesynced spec_helper.rb. It would make all these custom facts redundant.
There was a problem hiding this comment.
Agreed, but this would be out of scope for this PR IMHO.
|
Three commits and one PR is fine |
evgeni
force-pushed
the
pulp-cli-cert
branch
3 times, most recently
from
bbb8ac5 to
fae58b7
Compare
`puppet-certs` dropped the `pulp_client` certs, so let's use use the `foreman` ones instead
this comes from stdlib and is required in newer versions of the postgresql module
the correct parameter to `apache::vhost` is `serveraliases`, not `aliases`. the later is for folder aliases and has totally different syntax. Fixes: 2f9ada4
evgeni
changed the title
|
@ehelms this can now get a nice green checkmark ;-) |
ehelms
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.