Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Simplify variables in katello::qpid" #120

Closed
wants to merge 1 commit into from

Conversation

stbenjam
Copy link
Member

Reverts #119

This broke the pipeline:

21:49 [-beav > ==> centos7-devel:  qpid-config --ssl-certificate /etc/pki/katello/certs/centos7-devel.example.com-qpid-broker.crt --ssl-key                                                                        
               /etc/pki/katello/private/centos7-devel.example.com-qpid-broker.key -b 'amqps://centos7-devel.example.com:5671' bind event  '*.*' returned 1 instead of one of [0] 

@stbenjam
Copy link
Member Author

For some reason $candlepin_event_queue doesn't seem to be in scope. Maybe @ekohl has an idea why, but I'd be inclined to just revert this for now and revisit the clean-up later so the pipeline gets going again.

@beav
Copy link
Contributor

beav commented Apr 12, 2016

the pipeline itself is green, this is for devel setup but is also important 🐨

I'll do a run w/ this patch asap to see if it runs cleanly

@beav
Copy link
Contributor

beav commented Apr 12, 2016

I get a clean run after applying this patch and re-running foreman-installer (I was already set up to use the devel scenario).

@stbenjam
Copy link
Member Author

Ohhh sorry, thought I saw somethng on foreman-dev earlier. This is still likely the cause. For some reason $candlepin_event_queue isn't available when puppet-katello_devel calls ::katello::qpid.

@stbenjam
Copy link
Member Author

I see, katello_devel calls ::katello::qpid, but the top-level namespace (::katello) where candlepin_event_queue is, isn't loaded.

I guess the best fix would be for katello_devel to pass the queue explicitly.

This should fix it: theforeman/puppet-katello_devel#72

Will test.

But no need to revert this change IMHO.

@stbenjam stbenjam closed this Apr 12, 2016
@stbenjam stbenjam deleted the revert-119-simplify-qpid branch April 7, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants