Specify the candlepin event queue in katello_devel params #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,7 @@ | |||
| $initial_location = $katello_devel::params::initial_location, | |||
| $admin_password = $katello_devel::params::admin_password, | |||
| $enable_ostree = $katello::params::enable_ostree, | |||
| $candlepin_event_queue = $katello_devel::params::candlepin_event_queue, | |||
There was a problem hiding this comment.
The reason this works is $::katello_devel::params inherits from $::katello::params.
|
ACK this makes sense to me though I didn't test it. |
|
I get this error: |
We only call katello::qpid directly, and the katello top-level namespace isn't loaded when katello_devel is running, so the queue name doesn't resolve.
|
new patch works for me, clean run for devel setup! ACK |
|
There's a puppet-lint check for that. We use it in all theforeman modules so travis catches those for us. |
|
@ekohl Oh I see, we have the bits in our modulesync but it's not configured in the .sync.yml's, thanks! Filed http://projects.theforeman.org/issues/14599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only call katello::qpid directly, and the katello top-level namespace
isn't loaded when katello_devel is running, so the queue name
doesn't resolve.