Support Puppet 7 #174
Merged
Support Puppet 7 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-running tests. I expect some will be fixed by 30d4eca while others would still fail due to |
|
Rebased which also happens to trigger tests as well. |
Merged
|
Rebased again, let's see if the tests do pass now or if we really did hit a bug. |
|
It does look persistent. |
Forcing the locale in acceptance tests isn't pretty but for now it's a valid workaround. Note that the candlepin DB is already forced to en_US.UTF-8 but this affects initdb. We may see similar problems in production, but in general LANG should be matching a system locale.
ehelms
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.