Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #33751 - support ostree and python #236

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

jlsherrill
Copy link
Contributor

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for each in https://github.com/theforeman/puppet-pulpcore/tree/master/spec/classes and add them here:

let(:manifest) do
<<-PUPPET
include pulpcore
include pulpcore::plugin::ansible
include pulpcore::plugin::certguard
include pulpcore::plugin::container
include pulpcore::plugin::deb
include pulpcore::plugin::file
include pulpcore::plugin::migration
include pulpcore::plugin::rpm
PUPPET
end

Then we can see if the RPMs install and the service still comes up.

@ekohl ekohl added the Enhancement New feature or request label Oct 20, 2021
@jlsherrill
Copy link
Contributor Author

these errors don't look related, but i'm not sure

@jlsherrill
Copy link
Contributor Author

jlsherrill commented Oct 20, 2021

oh wait, it fails due to

Error: /Stage[main]/Pulpcore::Plugin::Ostree/Pulpcore::Plugin[ostree]/Package[pulpcore-plugin(ostree)]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/yum -d 0 -e 0 -y install pulpcore-plugin(ostree)' returned 1: Error: Nothing to do

i guess we need it packaged!

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these haven't been built for Pulp 3.14, we'll need to update this part: https://github.com/theforeman/puppet-pulpcore#support-policy

I'd prefer to keep supporting 3.14 while we can, but we should at least switch over to support 3.15 and test it in CI. We can do that in a separate PR. Is 3.15 something we can consume today?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #238 to support 3.15. This probably needs to be rebased once it's merged.

spec/acceptance/plugins_spec.rb Outdated Show resolved Hide resolved
@jlsherrill
Copy link
Contributor Author

updated, but still waiting on theforeman/pulpcore-packaging#308 + new repos to be published

spec/acceptance/plugins_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/plugins_spec.rb Outdated Show resolved Hide resolved
manifests/plugin/ostree.pp Show resolved Hide resolved
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can at least confirm that the logic to narrow it to EL8 with Pulp 3.15 works since that's the only thing that fails now :) Once theforeman/pulpcore-packaging#308 is merged & released I'd expect this to work.

@jlsherrill
Copy link
Contributor Author

this can now be re-tested, i don't think i have permissions to re-run them though

@ekohl
Copy link
Member

ekohl commented Oct 26, 2021

Kicked them off.

@jlsherrill
Copy link
Contributor Author

🟢

@ekohl ekohl merged commit 3392841 into theforeman:master Oct 26, 2021
@jlsherrill jlsherrill deleted the 33751 branch October 26, 2021 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants