-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #33751 - support ostree and python #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for each in https://github.com/theforeman/puppet-pulpcore/tree/master/spec/classes and add them here:
puppet-pulpcore/spec/acceptance/plugins_spec.rb
Lines 5 to 16 in 3c02ad4
let(:manifest) do | |
<<-PUPPET | |
include pulpcore | |
include pulpcore::plugin::ansible | |
include pulpcore::plugin::certguard | |
include pulpcore::plugin::container | |
include pulpcore::plugin::deb | |
include pulpcore::plugin::file | |
include pulpcore::plugin::migration | |
include pulpcore::plugin::rpm | |
PUPPET | |
end |
Then we can see if the RPMs install and the service still comes up.
these errors don't look related, but i'm not sure |
oh wait, it fails due to
i guess we need it packaged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these haven't been built for Pulp 3.14, we'll need to update this part: https://github.com/theforeman/puppet-pulpcore#support-policy
I'd prefer to keep supporting 3.14 while we can, but we should at least switch over to support 3.15 and test it in CI. We can do that in a separate PR. Is 3.15 something we can consume today?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened #238 to support 3.15. This probably needs to be rebased once it's merged.
updated, but still waiting on theforeman/pulpcore-packaging#308 + new repos to be published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can at least confirm that the logic to narrow it to EL8 with Pulp 3.15 works since that's the only thing that fails now :) Once theforeman/pulpcore-packaging#308 is merged & released I'd expect this to work.
this can now be re-tested, i don't think i have permissions to re-run them though |
Kicked them off. |
🟢 |
No description provided.