Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that plugin tasks are registered before accessing them #5869

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 6, 2019

What it does

fix #5861 - fire onCommand:workbench.action.tasks.runTask in order to activate VS Code extensions and register task providers

How to test

See #5861 (comment):

Review checklist

Reminder for reviewers

@akosyakov

This comment has been minimized.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov marked this pull request as ready for review August 6, 2019 12:23
@akosyakov akosyakov added tasks issues related to the task system vscode issues related to VSCode compatibility labels Aug 6, 2019
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested using the npm vscode-builtin-extension and can confirm that I now see
the tasks when executing the command Run Tasks....

The problem reported from #5861 is fixed.

@akosyakov
Copy link
Member Author

akosyakov commented Aug 6, 2019

I will let this PR sit till tomorrow if someone wants to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some plugins are not loaded in time
2 participants