Fix quick-pick initiated by the plugins not displaying with 1 item #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
akosyakov
reviewed
Aug 28, 2019
…item Fixes #6050 - fixes issue where `quick-pick` which were initiated by the plugins was not displayed when it only contains a single item. The fix is to include a new flag `runIfSingle` which is used to determine if the quick-pick should display or execute the item. - The default value for `runIfSingle` is set to `true`. - The `plugin-ext` sets the `runIfSingle` to `false` so it always displays the quick-pick regardless if an single item is present. This behavior is aligned with previous versions of Theia and VSCode. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
vf/GH-6050
branch
from
292b538
to
f294597
Compare
JPinkney
approved these changes
Aug 28, 2019
vinokurig
approved these changes
Aug 28, 2019
|
@vince-fugnitto please merge |
|
Thanks for the review @JPinkney @vinokurig :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #6050
quick-pickwhich were initiated by the plugins wasnot displayed when it only contains a single item. The fix is to include
a new flag
runIfSinglewhich is used to determine if the quick-pickshould display or execute the item.
runIfSingleis set totrue.plugin-extsets therunIfSingletofalseso it always displaysthe quick-pick regardless if an single item is present. This behavior is aligned
with previous versions of Theia and VSCode.
How to test
test that quick-pick with 1 items contributed through the plugin system always displays:
1.1. clone the example https://github.com/i053322/quickpickexample
1.2.
cd quickpickexample && npm i && npm run compile1.3. copy the
quickpickexampleunder thepluginsfolder1.4. start the application, run the command
Hello World(quick-pick should display)verify that quick-pick with 1 item work as usual in the app
2.2. start the app (with a single workspace), run the command
New Terminal(no quick-pick should be displayed)Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com