Improve HTML reporter #724 #801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest! Could you rework this against the master branch? (The changes should be pretty similar there.) We'd prefer to put new features in the Intern 4 code, at least for now. |
|
As far as the link styling goes, we can leave that at the default for now. |
vrozaev
force-pushed
the
improve-html-reporter
branch
from
048b9bc to
734e1a6
Compare
vrozaev
force-pushed
the
improve-html-reporter
branch
from
734e1a6 to
2091d99
Compare
|
Rework against master branch: #802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @dylans, hello @jason0x43!
I decide to help with #724 issue.
There is an initial pull request.
Known problems:
Icon for skipped tests is not exist.
There is a
$skippedIconvariable with\e807value inintern/lib/reporters/html/variables.styl, but fonts don't contain that character.I don't know how link should look like. Any ideas / markup / CSS class?
Need to write functional tests for that path.
Now it's looks like this:
