improve HTML - init commit

[vrozaev]

Hello @dylans, hello @jason0x43!

This pull request can fix several issues:
#636 #724

Now it's looks like this:

Feedback:
npm test serveOnly command say Listening on localhost:9000 (ws 9001) it's not comfortable - maybe it's should say Listening on http://127.0.0.1:9000/__intern/ (ws 9001)? In that case you can copy-paste this URL to browser.

If you prefer arrow function for callback - maybe you should add linter rule for that?
https://eslint.org/docs/rules/prefer-arrow-callback

[jason0x43]

Don't specify a return type when it's not necessary. Also applies to createLinkNode.

[vrozaev]

done

[jason0x43]

For consistency, prefer arrow functions for simple callbacks.

[vrozaev]

done

[jason0x43]

I like where this is going. Some thoughts:

• Use suites instead of grep (or both suites and grep if a specific test is being rerun) so that the only result in the re-run report will be the suite the user selected.
• Allow the location to be passed into the reporter, like the document property. Add it to HtmlProperties and make it a reporter property, then move createLinkNode and getFullName into Html as methods, or allow the location to be passed into createLinkNode. This will improve testability.

[jason0x43]

Also, the 'skipped' icon is rendering fine for me using Chrome on a Mac. Is there a particular browser you're seeing the issue with?

[vrozaev]

Also, the 'skipped' icon is rendering fine for me using Chrome on a Mac. Is there a particular browser you're seeing the issue with?

It was my mistake - I use outdated master branch.

[vrozaev]

Allow the location to be passed into the reporter, like the document property. Add it to HtmlProperties and make it a reporter property, then move createLinkNode and getFullName into Html as methods, or allow the location to be passed into createLinkNode. This will improve testability.

Done, but now i need window.encodeURIComponent function. So, can I just add window property to the HtmlProperties or I should write some provider for window.encodeURIComponent?

Use suites instead of grep (or both suites and grep if a specific test is being rerun) so that the only result in the re-run report will be the suite the user selected.

@jason0x43 Are you sure about that?
Suites param is array of string like path/to/suite1.js, ...etc. Program suites has specific name, like bdd.describe("My first suite!", () => {});. And it's can be several program suites in single file.
I didn't understand how i can correlate them witch each other.

Maybe we should build another html representation in case when grep property is specified? Show skipped tests in another (last) section or something like that?

[vrozaev]

@jason0x43 one more question. I tried to write tests but looks like i should register me mocks somehow. What i should do? Stacktrace:

(ノಠ益ಠ)ノ彡┻━┻
Error: A plugin named "createLocation" has not been registered
  at Node.Executor.getPlugin  <src/lib/executors/Executor.ts:322:10>
  at <tests/unit/lib/reporters/Html.ts:6:31>
  at Object.defineProperty.value  <_tests/tests/unit/lib/reporters/Html.js:3:17>
  at Object.<anonymous>  <_tests/tests/unit/lib/reporters/Html.js:9:3>

[jason0x43]

Assuming you want to use the same createLocation code in the browser and in Node, you don't need to deal with the plugin system, just do import { createLocation } from '../../../support/unit/mocks';. The setup used for DOM documents involves jsdom, and is a bit more complex than that to keep Intern from trying to load jsdom in browsers (or use the global document in Node).

[jason0x43]

So, how's this going? From the last CI error, it looks like the self tests are just missing a few commas.

[codecov-io]

Codecov Report

Merging #802 into master will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
- Coverage   92.96%   92.93%   -0.03%     
==========================================
  Files          54       54              
  Lines        4349     4361      +12     
  Branches      942      944       +2     
==========================================
+ Hits         4043     4053      +10     
- Misses        306      308       +2

Impacted Files	Coverage Δ
src/lib/reporters/Html.ts	90.16% <85.71%> (-0.29%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67ce151...4be0f00. Read the comment docs.

[vrozaev]

Well, I believe that feature itself is ready. There is only one little problem:

I can't just add test for suiteStart method because it's didn't actually add link anywhere. It's just store it in private property: this._runningSuites[suite.id] = { node: rowNode };. (I add test for testEnd method - now it's check that link for test exist.)

So - only one unit test left. Seems that I should call multiply methods if I want test this. It's sad - I was sure that I can call only suiteStart.

[jason0x43]

You could aspect document.createElement for the reporter's document, and verify whether the expected elements were created or not, maybe something like:

import { after } from '@dojo/core/aspect';

// ...

test() {
    let nodes: HTMLElement[] = [];
    after(reporter.document, 'createElement', (returnValue: any, args: IArguments) => {
        nodes.push(returnValue);
        return returnValue;
    });

    // do test

    // make assertions about created nodes
}

[vrozaev]

@jason0x43 It's ready now. Thanks for core/aspect - it's very useful.

[vrozaev]

@jason0x43 any news?

[jason0x43]

Hah, good timing, I was just reviewing it.

[jason0x43]

I made a couple minor changes (updated the createLinkNode method to use @dojo/core/UrlSearchParams and styled the URLs to use the text colors). Thanks for your contribution!