Fix casting to float when assigning numeric values; fixes normalization of integer arrays #837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
Newly, casting
adata.X
to thedtype
of the array it is assigned values from.Technical details
adata.X
being of a dtype which annot be casted to thedtype
ofvalues
(e.g. object if containing string) should not be a prominent problem, as this will trigger the set_numeric_values earlier during _assert_encoded.Additional context