Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Billboard v2 #141

Merged
merged 24 commits into from
Aug 20, 2024
Merged

Billboard v2 #141

merged 24 commits into from
Aug 20, 2024

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented Jun 27, 2024 •
edited
Loading

Features

Billboard

  • Open to mint billboard NFT;
  • Set whitelist for addresses can place bids;
  • Set board metadata by creator;
  • Set board AD data by auction bidder on any epoch in advance;

Auction & Bid

  • Place bids on any epoch;
  • Clear auction at the end of an epoch;
  • Withdraw non-winning bids;

Tax

  • Set a board-level tax rate on mint billboard;
  • Withdraw tax by board creator;

@robertu7 robertu7 requested review from zeckli and guoliu July 1, 2024 09:44
This was linked to issues Jul 1, 2024
Auction continuity and add preparation period #138
Closed
Access control changes #139
Closed
Refactor bids and related APIs #140
Closed
@robertu7 robertu7 changed the title WIP: Billboard v2 Billboard v2 Jul 3, 2024
@robertu7 robertu7 mentioned this pull request Jul 22, 2024
Merged
zeckli
zeckli approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@zeckli zeckli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go!

@zeckli zeckli merged commit 6dd813c into develop Aug 20, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/billboard-v2 branch August 20, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeckli zeckli zeckli approved these changes

@guoliu guoliu Awaiting requested review from guoliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor bids and related APIs Access control changes Auction continuity and add preparation period
2 participants
@robertu7 @zeckli