Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(billboard): add /qf-finalize and remove clear-auction-and-distribute-tax handler #147

Merged
merged 9 commits into from
Sep 3, 2024
Merged

feat(billboard): add /qf-finalize and remove clear-auction-and-distribute-tax handler #147

merged 9 commits into from
Sep 3, 2024

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented Jul 22, 2024 •
edited by gitwoz
Loading

  • Remove clear-auction-and-distribute-tax handler and unused code;
  • Add /qf-finalize to finalize a given round without recalculate score;
  • Add clear-auctions handler and support Billboard v2;

@robertu7 robertu7 linked an issue Jul 22, 2024 that may be closed by this pull request
Update Billboard Lambda #141
Closed
byhow
byhow reviewed Jul 30, 2024
View reviewed changes
handlers/clear-auctions.ts Outdated Show resolved Hide resolved
handlers/clear-auctions.ts Outdated Show resolved Hide resolved
handlers/clear-auctions.ts Outdated Show resolved Hide resolved
@robertu7
Copy link
Contributor Author

based on thematters/developer-resource#479, we no longer need the clear-auctions handler.

@robertu7 robertu7 changed the title feat(billboard): remove clear-auction-and-distribute-tax and add clear-auctions handler feat(billboard): remove clear-auction-and-distribute-tax handler Aug 27, 2024
@robertu7 robertu7 requested review from gary02 and byhow and removed request for byhow August 27, 2024 08:34
@gitwoz gitwoz self-requested a review August 29, 2024 08:23
@gitwoz gitwoz changed the title feat(billboard): remove clear-auction-and-distribute-tax handler feat(billboard): add /qf-finalize and remove clear-auction-and-distribute-tax handler Aug 29, 2024
zeckli
zeckli approved these changes Sep 2, 2024
View reviewed changes
Copy link

@zeckli zeckli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go.

@gitwoz gitwoz merged commit 1ecb9be into main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byhow byhow byhow left review comments

@zeckli zeckli zeckli approved these changes

@devformatters devformatters Awaiting requested review from devformatters

@gary02 gary02 Awaiting requested review from gary02

@gitwoz gitwoz Awaiting requested review from gitwoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Billboard Lambda
4 participants
@robertu7 @zeckli @byhow @gitwoz