Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use em instead of px as the font size unit #1006

Merged
merged 18 commits into from
Jul 30, 2019
Merged

Use em instead of px as the font size unit #1006

merged 18 commits into from
Jul 30, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 25, 2019 •
edited
Loading

Breaking Change

Since the default font unit is changed from px to em, if the font size has been set before, need to divide the value by 16

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang mentioned this pull request Jul 25, 2019
Closed
@stevenjoezhang stevenjoezhang requested review from 1v9 and jiangtj July 25, 2019 04:30
1v9
1v9 previously approved these changes Jul 25, 2019
View reviewed changes
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 25, 2019 •
edited
Loading

The margin of

  • menu
  • search pop-up
  • copy-code button

is sometimes wrong, I'll do more test

@1v9 1v9 dismissed their stale review July 25, 2019 04:52

need more test

@stevenjoezhang stevenjoezhang requested a review from 1v9 July 25, 2019 05:58
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 25, 2019
This was referenced Jul 26, 2019
Closed
Closed
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 26, 2019
Merged
@stevenjoezhang
Copy link
Contributor Author

stevenjoezhang commented Jul 26, 2019 •
edited
Loading

Docs here: theme-next/theme-next.org#35

Wait for v7.3.0 release

@stevenjoezhang stevenjoezhang removed this from the v7.3.0 milestone Jul 27, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 27, 2019
Closed
11 tasks
@1v9 1v9 added this to the v7.3.0 milestone Jul 30, 2019
@stevenjoezhang stevenjoezhang merged commit 5ce793b into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the font branch July 30, 2019 08:03
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 30, 2019
Closed
@1v9 1v9 added the 🌀 Fonts label Aug 13, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Sep 15, 2019
Closed
12 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@stevenjoezhang
Use em instead of px as the font size unit (theme-next#1006)
676029d
This was referenced Dec 1, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1v9 1v9 1v9 approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

@jiangtj jiangtj Awaiting requested review from jiangtj

Assignees
No one assigned
Labels
💥 Breaking Change 🌀 Fonts 🛠 Improvement 🎯 Roadmap
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenjoezhang @1v9