-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all hardcoded font sizes with replacing them on em
#726
Conversation
This reverts commit 0854983.
Yes, there is. |
em
.em
.
em
.em
.
em
.em
.
As a bug fix, I think it is still necessary to be merged ASAP. Switch on |
Nice counterattack!😉 |
I remember it too, yeah. But there is another situation: more things I've seen – breaked. It's actually most global refactoring, and move like this can't be only bugfix. If we start to refactor fonts, to remove hardcore styles, to change font sizes, etc., well, needed to make it beautiful. Making it at once and forgot about it... As about talking mixed features / bugfixes / improvements: I will not edit in this PR button styles, fixes in swig or additions in js, u know? I'll do only what related to the Fonts, no less no more. And seems this PR not enter in tomorrow release, because there are many, many changes and need to carefully test it too. Important thing: don't hurry. Coz we already have a lot of changes in future v7.1.0 release. |
And actually this will be Improvement. Not Bug Fix and not Feature. Just Font will be better = Improvement. |
em
.em
.
em
.em
em
em
@ivan-nginx |
Ok, I'll see it detailed later. For now as I see, seems it what NexT needed. Also, I don't find headers (H1-H6), I was implemented this function from Gemini (deleted lines in this PR). Don't hurry, we make this fonts ideal. |
They're still here, you can check again
No need to resume them. Why they were deleted? Because the target of this PR is Remove all hardcoded font sizes You can push your changes/commits to font-refactoring branch, and I'll merge my commits, then let's do the further tests. Don't hurry, but can be more efficiency. |
Resuming for #723 pull.