Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility #130

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Improve accessibility #130

merged 1 commit into from
Mar 14, 2018

Conversation

maple3142
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Get 45 on accessibility on lighthouse.
report

Issue Number(s): N/A

What is the new behavior?

Get 90 on accessibility on lighthouse.
report

How to use?

Nothing.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@@ -1,6 +1,6 @@
<meta charset="UTF-8"/>
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1"/>
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=2"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not to do site larger by double click?

Copy link
Contributor Author

@maple3142 maple3142 Feb 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
here said shouldn't disable zoom

Copy link

@songouyang songouyang Jun 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but in wechat, a zoom buttom in lower right corner appears. could it be optional in _config.yml? @maple3142
374975667

@ivan-nginx ivan-nginx added this to the v6.0.6 milestone Mar 14, 2018
@ivan-nginx ivan-nginx changed the title improve accessibility Improve accessibility Mar 14, 2018
@ivan-nginx ivan-nginx merged commit 00c8ebc into theme-next:master Mar 14, 2018
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
lkv1988 pushed a commit to lkv1988/hexo-theme-next that referenced this pull request Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants