`back2top` button on mobile, sidebar item margin and sidebar `exturl` link color #684

stevenjoezhang · 2019-03-14T02:15:40Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines.
Tests for the changes was maked (for bug fixes / features).
- Muse | Mist have been tested.
- Pisces | Gemini have been tested.
Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue resolved: #482

What is the new behavior?

Fixed 3 bugs:

Next的Pisces主题样式在移动端似乎没有Back to Top的功能？ #482, make back2top display on mobile
Add spaces between sidebar elements
Add border-bottom-color settings of exturl in sidebar
Screenshots with this changes: N/A

Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

Yes.
No.

ivan-nginx

Need some changes here.

Also, when u create visual fixes like this, make and upload screens please. Sometimes it's hard for understanding where was makes changes.

ivan-nginx · 2019-03-16T16:55:11Z

source/js/src/post-details.js

@@ -89,8 +89,7 @@ $(document).ready(function() {
  var display = CONFIG.page.sidebar;
  if (typeof display !== 'boolean') {
    // There's no definition sidebar in the page front-matter
-    var isSidebarCouldDisplay = CONFIG.sidebar.display === 'post'
-     || CONFIG.sidebar.display === 'always';
+    var isSidebarCouldDisplay = CONFIG.sidebar.display === 'post' || CONFIG.sidebar.display === 'always';


This will brake ESLinter under the NexT.. Revert this.

ivan-nginx · 2019-03-16T16:55:24Z

source/css/_schemes/Pisces/_sidebar.styl

+
+    &:hover { color: $black-deep; }
+  }
+  .exturl:hover { border-bottom-color: $black-deep; }


span.exturl (for fater element finding)

ivan-nginx · 2019-03-16T16:55:27Z

source/css/_common/components/sidebar/sidebar.styl

@@ -15,6 +15,9 @@
    border-bottom-color: $black-light;
    &:hover { color: $gainsboro; }
  }
+  .exturl:hover {


span.exturl (for fater element finding)

ivan-nginx · 2019-03-16T17:08:52Z

No need to take your time on labels «10px» / «15px». 😄 Just make screens during you make your changes and upload them directly from clipboard buffer here in GitHub. This will take minimal time.

stevenjoezhang · 2019-03-16T17:14:09Z

Maybe this step also needs to be automated. 😂 For example, there are 4 different components in the sidebar, each one can be enabled/disabled, then there are 2^4=16 combinations in total... need to make sure they are all suitable, and it takes time for human to test.

ivan-nginx · 2019-03-16T17:17:03Z

And please, create labels instead of that:

Bugfix: b2t on mobile (#482), sidebar item margin and sidebar link color**

Like this:

Fixed `back2top` on mobile & modified sidebar item margin and sidebar `extlurl` color**.

Titles like that already completed for simple pasting into the releases notes and to the NexT site, without needed to modify them.

If back2top → it's already good to write it as option:

hexo-theme-next/_config.yml

Line 268 in 2e0b6ca

back2top:

Same for exturl:

hexo-theme-next/_config.yml

Line 140 in 2e0b6ca

exturl: false

ivan-nginx · 2019-03-16T17:21:04Z

Maybe this step also needs to be automated. For example, there are 4 different components in the sidebar, each one can be enabled/disabled, then there are 2^4=16 combinations in total... need to make sure they are all suitable, and it takes time for human to test.

Nobody talk NexT is easy. ;)
Main of Vi's thinking also was: anything can be a component.
All things need to do simplier, smaller. If files can be splitted on several pieces → this also great choice of good coding.

ivan-nginx

And, yes, there is no feature, just label «CSS» and «Code style update».

ivan-nginx · 2019-03-16T17:27:14Z

Please, no need to paste issues inside titles. They already exists in PR content and issue will auto-closed:

stevenjoezhang · 2019-03-16T17:28:49Z

@ivan-nginx Thanks 👍 I learned a lot here.

ivan-nginx · 2019-03-16T17:37:58Z

@stevenjoezhang also, if there is label Bug Fix and there are no Breaking Changes, don't forget to add v6.x label for cherry-pick this PR into version 6 in accordance with this #567 issue.

… link color (theme-next#684) * Bugfix: show `back2top` button on mobile (theme-next#482) * Optimize sidebar item margin * Fix wrong `exturl` link color

b2t

c2b53b5

stevenjoezhang added ⭐ Feature 🐞 Bug Fix labels Mar 14, 2019

stevenjoezhang requested review from ivan-nginx, 1v9, jiangtj and maple3142 March 14, 2019 06:09

stevenjoezhang added 2 commits March 14, 2019 16:45

Update back-to-top-sidebar.styl

f66858d

update

f63c9bd

1v9 removed their request for review March 14, 2019 11:25

stevenjoezhang changed the title ~~Fix #482: b2t on mobile~~ Fix #482: b2t on mobile and sidebar item margin Mar 15, 2019

update

6a58a55

stevenjoezhang removed the ⭐ Feature label Mar 15, 2019

stevenjoezhang changed the title ~~Fix #482: b2t on mobile and sidebar item margin~~ Bugfix: b2t on mobile (#482), sidebar item margin and sidebar link color Mar 15, 2019

button color

8e8f1d4

ivan-nginx requested changes Mar 16, 2019

View reviewed changes

update

1d47159

ivan-nginx added this to the v7.1.0 milestone Mar 16, 2019

stevenjoezhang changed the title ~~Bugfix: b2t on mobile (#482), sidebar item margin and sidebar link color~~ Bugfix: back2top button on mobile (#482), sidebar item margin and sidebar exturl link color Mar 16, 2019

ivan-nginx approved these changes Mar 16, 2019

View reviewed changes

ivan-nginx changed the title ~~Bugfix: back2top button on mobile (#482), sidebar item margin and sidebar exturl link color~~ Bugfix: back2top button on mobile, sidebar item margin and sidebar exturl link color Mar 16, 2019

stevenjoezhang added the CSS label Mar 16, 2019

stevenjoezhang merged commit 8a9b7e9 into theme-next:master Mar 16, 2019

stevenjoezhang deleted the b2t branch March 16, 2019 17:36

stevenjoezhang added the v6.x label Mar 16, 2019

liolok changed the title ~~Bugfix: back2top button on mobile, sidebar item margin and sidebar exturl link color~~ back2top button on mobile, sidebar item margin and sidebar exturl link color Mar 31, 2019

This was referenced Apr 4, 2019

No sidebar in mobile when it open #807

Closed

Option onmoble for sidebar wasn't worked #808

Merged

stevenjoezhang mentioned this pull request Oct 16, 2019

Next的Pisces主题样式在移动端似乎没有Back to Top的功能？ #482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`back2top` button on mobile, sidebar item margin and sidebar `exturl` link color #684

`back2top` button on mobile, sidebar item margin and sidebar `exturl` link color #684

stevenjoezhang commented Mar 14, 2019 •

edited

Loading

ivan-nginx left a comment •

edited

Loading

ivan-nginx Mar 16, 2019

stevenjoezhang Mar 16, 2019

ivan-nginx Mar 16, 2019

ivan-nginx Mar 16, 2019

ivan-nginx commented Mar 16, 2019 •

edited

Loading

stevenjoezhang commented Mar 16, 2019

ivan-nginx commented Mar 16, 2019

ivan-nginx commented Mar 16, 2019

ivan-nginx left a comment

ivan-nginx commented Mar 16, 2019

stevenjoezhang commented Mar 16, 2019

ivan-nginx commented Mar 16, 2019

back2top button on mobile, sidebar item margin and sidebar exturl link color #684

back2top button on mobile, sidebar item margin and sidebar exturl link color #684

Conversation

stevenjoezhang commented Mar 14, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

How to use?

Does this PR introduce a breaking change?

ivan-nginx left a comment • edited Loading

Choose a reason for hiding this comment

ivan-nginx Mar 16, 2019

Choose a reason for hiding this comment

stevenjoezhang Mar 16, 2019

Choose a reason for hiding this comment

ivan-nginx Mar 16, 2019

Choose a reason for hiding this comment

ivan-nginx Mar 16, 2019

Choose a reason for hiding this comment

ivan-nginx commented Mar 16, 2019 • edited Loading

stevenjoezhang commented Mar 16, 2019

ivan-nginx commented Mar 16, 2019

Bugfix: b2t on mobile (#482), sidebar item margin and sidebar link color**

Fixed back2top on mobile & modified sidebar item margin and sidebar extlurl color**.

ivan-nginx commented Mar 16, 2019

ivan-nginx left a comment

Choose a reason for hiding this comment

ivan-nginx commented Mar 16, 2019

stevenjoezhang commented Mar 16, 2019

ivan-nginx commented Mar 16, 2019

`back2top` button on mobile, sidebar item margin and sidebar `exturl` link color #684

`back2top` button on mobile, sidebar item margin and sidebar `exturl` link color #684

stevenjoezhang commented Mar 14, 2019 •

edited

Loading

ivan-nginx left a comment •

edited

Loading

ivan-nginx commented Mar 16, 2019 •

edited

Loading

Fixed `back2top` on mobile & modified sidebar item margin and sidebar `extlurl` color**.