refactor: Remove makeStyles classes in favour of styled components
#1707
Conversation
DafyddLlyr
force-pushed
the
dp/cull-makestyles
branch
from
d1f7e6d to
0edd1f5
Compare
| "@mui/material": "5.12.3", | ||
| "@mui/styles": "5.12.3", | ||
| "@mui/utils": "5.12.3", |
There was a problem hiding this comment.
This version bump fixed the annoying bug where the "Change" text within a button on the SummaryList wasn't correctly inheriting the font-family.
However, upgrading right to the latest version (5.13.1) was causing issues which I spent a lot of time trying to resolve. This version just came out a few days ago so hopefully it's something that will get ironed out shortly.
| const classes = { | ||
| tabs: `${PREFIX}-tabs`, | ||
| tabIndicator: `${PREFIX}-tabIndicator`, | ||
| }; |
There was a problem hiding this comment.
I see that this is retained because of lines 134-137. What function do classes still have on the Tab component after this change?
|
Converted to draft until #1648 is reviewed and merged, and I've then re-based this 👌 |
|
Update from dev call - I'll keep this open as a reference for a while, but cherry-pick out commits to split this up into a series of smaller and simpler PRs 🍒 |
|
Closed - over the next few days or weeks, I'll just cherry-pick into individual PRs as we go along 🍒 |
Boring and repetitive work which helped the long train journey pass well yesterday!
There may be a few concerns with conflicts against some of Ian's work but I'm happy to rebase this, or even cherry-pick out commits that we can take forward a bit at a time. I appreciate there's a decent amount here for one PR sorry.