feat: Styled Calculate
#1802
Merged
feat: Styled Calculate
#1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Jun 19, 2023
| <InputRow key={variable}> | ||
| <Input value={variable} disabled /> | ||
| <span className={classes.were}>were</span> | ||
| <Were>were</Were> |
There was a problem hiding this comment.
nit: totally appreciate this isn't introduced here, but this language feels a little awkward ! Is something like <ConditionLabel> clearer than <Were> ?
in the future, perhaps we can further simplify to "If {x} 'is {y}, then {fn} will be set to {output}".
But happy for this to be revisited, no need to open that can of worms now !
There was a problem hiding this comment.
Yeah this is totally fair - I felt this was awkward and couldn't hit on a good name. Will go for ConditionLabel thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #1707 🍒