fix: ensure reconciliation behaves as expected and does not result in orphaned breadcrumbs #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss/reconciliation-bug
jessicamcinchak
commented
Jan 28, 2025
| // remove all auto-answered breadcrumbs | ||
| // (auto-answers are reconstructed in the editor by `upcomingCards`) | ||
| // remove all auto-answered breadcrumbs because their automation may rely on the same data values as an altered node | ||
| // (auto-answers can be reconstructed on forwards navigation if they are still auto-answerable on resume) |
There was a problem hiding this comment.
See existing test('auto-answered breadcrumbs with matching "data.val" values are also removed') in validateSession.test.ts to better understand this. I ultimately believe this is correct behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-progress investigation based on https://opensystemslab.slack.com/archives/C088K9ZL8EA/p1737533997179459
What I still want to check:
e5d22126-98f9-4e47-99f3-9c86265d6ae3was invite-to-pay which would have "skipped" reconciliation - should reconciliation have a basic version of reconciliation to at minimum remove now-orphaned breadcrumbs or should the payload generation be adjusted to join to the version of the published flow when the session waslocked_at?229f0f51-7101-4c5a-adaf-7c159b8d7b20was not invite-to-pay, but had a near-full-month lapse between starting & submittingTODOcomments at the top ofapi.planx.uk/modules/saveAndReturn/service/validateSession.ts