Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure reconciliation behaves as expected and does not result in orphaned breadcrumbs #4218

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: ensure reconciliation behaves as expected and does not result in orphaned breadcrumbs #4218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68a0e58
correct comment
jessicamcinchak Jan 26, 2025
812ee34
Merge branch 'main' of github.com:theopensystemslab/planx-new into je…
jessicamcinchak Jan 28, 2025
ddab417
wip
jessicamcinchak Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api.planx.uk/modules/saveAndReturn/service/validateSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ async function reconcileSessionData({
}
};

// remove all auto-answered breadcrumbs
// (auto-answers are reconstructed in the editor by `upcomingCards`)
// remove all auto-answered breadcrumbs because their automation may rely on the same data values as an altered node
// (auto-answers can be reconstructed on forwards navigation if they are still auto-answerable on resume)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See existing test('auto-answered breadcrumbs with matching "data.val" values are also removed') in validateSession.test.ts to better understand this. I ultimately believe this is correct behavior

for (const [id, crumb] of Object.entries(sessionData.breadcrumbs)) {
if (crumb.auto === true && sessionData.breadcrumbs[id]) {
delete sessionData.breadcrumbs[id];
Expand Down
Loading