Upgrade eslint-config in dApp module #99
Labels
🎨 dapp
dApp
Comments
This was referenced Dec 28, 2023
r-czajkowski
added a commit
that referenced
this issue
Jan 4, 2024
Update `@thesis-co/eslint-config` to the latest version. The commit hash refers to the merge commit of thesis/eslint-config#12. This version enables `@typescript-eslint/recommended-type-checked` rules. The configuration enforces multiple typing check rules that I found very useful in the core module's typescript tests, where we were missing `await` in a couple of places. Example: ```ts it("should emit StakeReferral event", () => { expect(tx) .to.emit(acre, "StakeReferral") .withArgs(referral, amountToStake) }) ``` Without the `await` the test returned a false-positive result and hadn't checked if expect resolves correctly.⚠️ Typing checks in the Core module require `typechain/` directory to be generated before eslint verification is run. It is recommended that on local environments `pnpm run build` is run before `pnpm run format`. In this PR we update the CI process accordingly. This PR updates the configuration of the Core, SDK, and Website modules. This PR doesn't update the configuration of the dApp module, we should handle that in #99.
Merged
nkuba
added a commit
that referenced
this issue
Jan 11, 2024
Refs: #99 Updated "@thesis-co/eslint-config" version to "github:thesis/eslint-config#7b9bc8. Due to the above change, it was necessary to add a few eslint rules. If we have time for it, we can also address changes to the related components to limit the number of added rules. The rule "@typescript-eslint/no-unsafe-member-access", applies to an external library that does not fit into our default eslint configuration, hence the need to leave it.
r-czajkowski
added a commit
that referenced
this issue
Jan 23, 2024
Fix problems reported by eslint but disabled in dapp/.eslintrc. Closes: #99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #98 we updated eslint configuration to the latest version of
@thesis-co/eslint-configfor Core, SDK, and Website modules.When working on this issue we should introduce a similar change in the dApp module.
This issue will be handled in two stages:
dapp/.eslintrc.The text was updated successfully, but these errors were encountered: