Use typescript recommended-type-checked rules #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switch from [`@typescript-eslint/recommended`](https://typescript-eslint.io/linting/configs/#recommended) to [`@typescript-eslint/recommended-type-checked`](https://typescript-eslint.io/linting/configs/#recommended-type-checked). The new configuration extends the previous one with additonal rules related to types checking.
We disable the `plugin:@typescript-eslint/recommended-type-checked"` rules for JS files as recommended in https://typescript-eslint.io/linting/typed-linting#how-can-i-disable-type-aware-linting-for-a-subset-of-files
Shadowfiend
approved these changes
Dec 22, 2023
nkuba
added a commit
to thesis/acre
that referenced
this pull request
Dec 28, 2023
This version enables `@typescript-eslint/recommended-type-checked` rules. The commit hash refers to the merge commit of thesis/eslint-config#12.
nkuba
added a commit
to thesis/acre
that referenced
this pull request
Dec 28, 2023
This version enables `@typescript-eslint/recommended-type-checked` rules. The commit hash refers to the merge commit of thesis/eslint-config#12.
nkuba
added a commit
to thesis/acre
that referenced
this pull request
Dec 28, 2023
This version enables `@typescript-eslint/recommended-type-checked` rules. The commit hash refers to the merge commit of thesis/eslint-config#12.
Please find the reference PR here: thesis/acre#98 |
r-czajkowski
added a commit
to thesis/acre
that referenced
this pull request
Jan 4, 2024
Update `@thesis-co/eslint-config` to the latest version. The commit hash refers to the merge commit of thesis/eslint-config#12. This version enables `@typescript-eslint/recommended-type-checked` rules. The configuration enforces multiple typing check rules that I found very useful in the core module's typescript tests, where we were missing `await` in a couple of places. Example: ```ts it("should emit StakeReferral event", () => { expect(tx) .to.emit(acre, "StakeReferral") .withArgs(referral, amountToStake) }) ``` Without the `await` the test returned a false-positive result and hadn't checked if expect resolves correctly.⚠️ Typing checks in the Core module require `typechain/` directory to be generated before eslint verification is run. It is recommended that on local environments `pnpm run build` is run before `pnpm run format`. In this PR we update the CI process accordingly. This PR updates the configuration of the Core, SDK, and Website modules. This PR doesn't update the configuration of the dApp module, we should handle that in #99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switch from
@typescript-eslint/recommendedto@typescript-eslint/recommended-type-checked.The new configuration extends the previous one with additional rules related to type information.