-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESSX8326 HID not supported: No sound on GPD pocket 3 #3393
Comments
If you can extract ACPI tables that would be useful. Install acpica-tools on your device and acpixtract -a acpidump, then attach the gzipped binary. |
PCI ID 4dc8 -> JasperLake |
I'm not sure it is exactly what you asked for but here is the output of acpidump gziped |
The tables show we should use SSP0 for the connection, and it's indeed an audio codec. I don't know how to interpret the GPIO data, @hli25 can you help (might happen after CNY). |
From the dsdt.dsl, the first gpio should be pa_enable, this is default setting in current machine driver. The second one is for interrupt. This is compatible with current machine driver. However, synced with @yangxiaohua2009,ESSX8326 need new codec driver. copied codec _CRS from dsdt.dsl.txt:
|
What do you mean @hli25 @yangxiaohua2009? In the latter case, the machine driver wouldn't work since it would rely on the wrong components in the dailink. These platforms are on their way to beat Baytrail in terms of general confusion and lack of drivers...Oh well. |
Thanks @hli25. Is there a way to detect which GPIO is used for what directly from the DSDT? That would remove the need for quirks for the pa_enable, that would be really good. |
ES8326 is a completely different hardware compared with ES8316. |
Hi Pierre, |
Here's a set of comments to bring this code to a level of quality compatible with upstream requirements
|
Updated code. @plbossart |
I might be wrong but I wanted to test it,
and ran so the error seemed to be that symmetric_rates doesn't exist but symmetric_rate does (I looked up and it is on the soc.h)
Anyway, I suppose you know what you are doing more than me but I wanted to give it a try anyway (worst case scenario, I will load my backup and I will be gtg again) so I replaced it with then compile and it worked I now have a es8326.ko file that I wanted to load so I tried to load it with So here I am ^^ This whole thing might be irrelevant but I wanted to share in case there is anything useful in it Anyway thank you for you work! it is really appreciated |
The code looks mostly ok @yangxiaohua2009 but I would recommend you submit a proper PR or patch with your Signed-off-by tag, otherwise it's hard to review. You would also want to have the Makefile changes so that people can compile and run tests. I also noted that the indentation is off, and that you didn't cleanup the 'master/slave' references. |
Created a PR. @plbossart |
again, I'm really not an expert but I tried to pull your branch, I compiled it and now I'm running it, I clearry can be wrong but I tried with and without dsp config to 1 and either doesn't work for me can I give any info on that ? |
Hello, https://www.indiegogo.com/projects/pocket-3-a-modular-and-full-featured-handheld-pc#/updates/28 |
This update should solve your problem, go ahead and install it. Will ask the GPD team to update their kernel later. |
as I'm on archlinux and because this uses deb packages I have to decompile
this update and try to apply it to my distro.
I tried yesterday and this updated has to replaced some file in lib... at
first I didn't want to do that but I finaly did as I have a backup in case
it goes wrong...
at the end I had to load my backup because the computer wouldn't turn on
after that (kernel panic) now I will try to find my way to get only the
necessary files for this update but this will take time
I don't blame you at all, I know that this is long process that takes time
for you too but I hope this will get upstream one day ^^
Thanks a lot for all your work tho!
Le mar. 15 févr. 2022 à 09:03, yangxiaohua2009 ***@***.***> a
écrit :
… Hello, Today the gdk team released what they call "sound firmware for
N6000" (this is the firmware I own) this is great in a way but this took me
3 sec by looking to the process to see that they don't really know what
they are doing and I can't really trust that, I will try to analyze and
install it my own way to see if it works but maybe this could be usefull
for any of you ?
https://www.indiegogo.com/projects/pocket-3-a-modular-and-full-featured-handheld-pc#/updates/28
This update should solve your problem, go ahead and install it. Will ask
the GPD team to update their kernel later.
—
Reply to this email directly, view it on GitHub
<#3393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGIN2VGG2SFLHAEXR7ZGAYDU3IJEJANCNFSM5MY2MYVQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Running kernel 5.17.5 and audio still does not work for this device. I would like to help look into this issue as these devices are in far more hands now than back at initial launch. Here is my dmesg info regarding the hardware:
|
I can confirm that the issue is not solved for me ^^ |
here is the new alsa-info.sh in case this can help ? |
@tonitch the error is 'normal', -517 means 'deferred probe'. The machine driver expects resources that are not available. That's again normal, you have a 8326 codec, not 8336, and the codec driver is not upstream so there's no component registered to make the machine driver happy. You will have to ask nicely to the vendor to complete this work. @yangxiaohua2009 FYI https://lore.kernel.org/alsa-devel/YkxL51j8E11u0uV%2F@sirena.org.uk/ |
Please tried the patch and tell us if you can hear sound from headphone. |
Which patch do you mean ? If you talk about the patch I told you the gpd team published, it was a piece of security nightmare. But I tried it anyway, it didn't worked and the god team removed the patch not even a week after -_- They don't know linux and don't really try to support it unfortunately. I'm trying to dig myself and understand what is happening (following things I find on lwn on acpi for instance) but this is the first time and I honestly don't really know what I am doing... Hopefully, one day this sound card model will be supported one way or the other I talked with tomty89 on #linux who made this post tho #4591 I don't know if this concert my card too or not at all Ps: I really understand that you are volunteer and don't want to disrespect at all in any way 😉 |
Please use this patch on your kernel source code because the code is out of main branch. |
It took me sooo long to compile but yhea it finally worked ! thanks a lot, I will close this issue! I suppose you can push that to the main branch somehow ^^ |
@yangxiaohua2009 - I am not a firmware developer, but it had sounded like this patch worked great for @tonitch, was just wondering why plbossart#25 was closed If it works, this would be a great thing to have upstream so that other users could benefit from not needing to custom compile their kernel for audio support on a device with ESSX8326 HID :) |
I've spent the last couple days trying to get this to work without much success. @tonitch - how did you get it working in arch? I am in arch linux as well
|
For anyone potentially stuck on this in the future... the patch works great, but in my case I had disabled It seems that kernel option is necessary to communicate with the 8336/8326 when on the intel SoC |
@yangxiaohua2009 - I'm noticing audio popping with this codec, is this expected? |
You need to enable SND_SOC_INTEL_SOF_ES8336_MACH otherwise you won't have soundcard. |
@yangxiaohua2009 , yup that's what I was mentioning in my comment. I had that disabled but it needed to be enabled Do you know why this audio codec has popping issues? Also are there any plans to merge this upstream? |
Based on ALSA SoF development branch. Refer to: Link: thesofproject#3393 Link: thesofproject#3508 Signed-off-by: Vasily Vinogradov <v.vinogradov@aq.ru> Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
I was about to compile the newest Arch kernel with this patch but realized it was already applied. It turns out this patch have been merged upstream and is in Linux since version 6.1. |
Following the mail sent on alsa-devel : https://mailman.alsa-project.org/pipermail/alsa-devel/2022-January/195187.html
@plbossart asked to post and issue here
the sound doesn't work even with dsp_driver set to 1 or 3
here is the alsa-info : http://alsa-project.org/db/?f=7f788dae384202786108c0deceb50b87d6b234d8
The text was updated successfully, but these errors were encountered: