ASoC: codecs: add support for ES8326 #3508
Conversation
yangxiaohua2009
requested review from
lgirdwood,
plbossart,
ranj063,
kv2019i,
dbaluta,
bardliao,
ujfalusi,
ajitkupandey,
kuanhsuncheng and
yaochunhung
as code owners
|
Can one of the admins verify this patch?
|
|
test this please |
|
@plbossart compile issue fixed. The codec driver may need to be rewrited to be compatible with ucm sof-essx8336. |
|
test this please |
| amic2-src = [19]; | ||
| jack-pol = [0e]; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Usually dt-bindings are in a separate patch (they need to be acked by DT maintainers)
There was a problem hiding this comment.
Can I submit the dt-binding patch later?
There was a problem hiding this comment.
I personally don't care, but keep in mind this will be asked for upstream so you have to work on this.
|
test this please |
|
SOFCI TEST |
sound/soc/codecs/es8326.c
Outdated
| if (ret == 0) | ||
| disable_irq(es8326->irq); | ||
| else | ||
| dev_warn(&i2c->dev, "Getting irq failed."); |
There was a problem hiding this comment.
can this driver work without the IRQ? if no, should an error be returned?
There was a problem hiding this comment.
it's good that you added a workqueue for jack detection, but that needs to be handled in a .remove function.
also please split the DT bindings in a separate patch.
With those changes, I think this is starting to be ready for upstream in the next kernel cycle. Thanks @yangxiaohua2009
sound/soc/codecs/es8326.c
Outdated
| unsigned int sysclk; | ||
| }; | ||
|
|
||
| static void es8326_jack_detect_handler(struct work_struct *work){ |
There was a problem hiding this comment.
brace should be at start of line.
| jack-pol = [0e]; | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
this should be a separate patch, so that DT reviewers can take a look without having to look at the driver code.
There was a problem hiding this comment.
separate patch in #3546
|
@yangxiaohua2009 This looks good enough to me, please send this patch and the device-tree one to alsa-devel@alsa-project.org and CC: maintainers |
The ES8326 codec is not compatible with ES8316 and requires a dedicated driver. Signed-off-by: David Yang <yangxiaohua@everest-semi.com>
|
closing, this will be handled with an upstream merge. |
Based on ALSA SoF development branch. Refer to: Link: thesofproject#3393 Link: thesofproject#3508 Signed-off-by: Vasily Vinogradov <v.vinogradov@aq.ru> Signed-off-by: Nikolai Kostrigin <nickel@altlinux.org>
The ES8326 codec is not compatible with ES8316 and requires a dedicated driver.
Signed-off-by: David Yang yangxiaohua@everest-semi.com