Set of a new hash computing functions (SP1) #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborisovich
suggested changes
Feb 27, 2023
softwarecki
requested review from
aborisovich,
pblaszko,
pjdobrowolski,
marcinszkudlinski,
RanderWang,
juimonen,
kv2019i and
abonislawski
pblaszko
reviewed
Feb 27, 2023
marcinszkudlinski
previously requested changes
Feb 27, 2023
aborisovich
suggested changes
Feb 27, 2023
This function will be used in different places in the code, so I moved it to a separate file. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Prepared a new set of functions for computing digest with error handling. The hash context has been placed into a separate structure. This allows to conveniently pass the calculated digest along with its length and used algorithm. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Switched to use new hash functions. The parameter list for the rimage_sign and rimage_verify functions has been simplified. The necessary information is now included in the hash_context structure. In addition, code fragments that may be common to different versions of the manifest have been separated. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Removed currently unused functions. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Fields related to hash computing have been removed from the image structure. Removed openssl headers from rimage.h, which made it necessary to add some missing includes in several files. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
pjdobrowolski
approved these changes
Mar 1, 2023
aborisovich
approved these changes
Mar 1, 2023
|
This does not compile, fix submitted in #144 |
|
It's pretty easy to submit a temporary/draft/throw-away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved byte_swap function to a new misc_utils.c file. This function will be used in different places in the code.
Prepared a set of fa new unctions for computing digest with error handling. The hash context has been placed into a separate structure. This allows to conveniently pass the calculated digest along with its length and used algorithm.
Switched to use new hash functions. The parameter list for the rimage_sign and rimage_verify functions has been simplified. The necessary information is now included in the hash_context structure. In addition, code fragments that may be common to different versions of the manifest have been separated.
Fields related to hash computing have been removed from the image structure. Removed openssl headers from rimage.h, which made it necessary to add some missing includes in several files.