rimage: fix build error #144
Conversation
Recent changes introduce build error, fix the build error. Signed-off-by: Chao Song <chao.song@linux.intel.com>
| @@ -338,8 +338,6 @@ static int rimage_verify(EVP_PKEY *privkey, enum manver ver,struct hash_context | |||
| fprintf(stderr, "error: verify %s\n", err_buf); | |||
| } | |||
|
|
|||
| break; | |||
|
|
|||
| out: | |||
There was a problem hiding this comment.
why do you remove the break? It doesn't seem to belong to this patch if you really want to remove it.
There was a problem hiding this comment.
the break is in the middle of a function outside switch statement... so probably some copy/paste error, probably better just to remove. I mean this break was introduced in the same patch @aiChaoSONG is trying to fix here.
There was a problem hiding this comment.
ok, so we are fixing a copy/paste error in the previous patch .
There was a problem hiding this comment.
Thanks @aiChaoSONG . Would be nice to add a reference to the commit that added the regression (d258ea2). Obviously some basic build tests would be needed here. Now that we are using west for rimage, we'll find issues like this much later. And e.g. today, we'd have a critical update for rimage, but we can update rimage as the current head doesn't build. :(
| @@ -338,8 +338,6 @@ static int rimage_verify(EVP_PKEY *privkey, enum manver ver,struct hash_context | |||
| fprintf(stderr, "error: verify %s\n", err_buf); | |||
| } | |||
|
|
|||
| break; | |||
|
|
|||
| out: | |||
There was a problem hiding this comment.
ok, so we are fixing a copy/paste error in the previous patch .
|
Ok, let initially fix the build to unblock everyone and the testing infra. Second step is to see what's needed to get CI building rimage. |
|
|
Actually, it's pretty easy to submit a temporary/draft/throw-away So maybe have more |
|
I think that testing through sof CI will not solve the problem either. We have sections of code that depend on openssl version. The error appeared into the section for a different version of openssl than is used in rimage CI I think that sof CI also uses only one openssl version. Rather, we should expand CI to use several openssl versions and perform image signatures and verification for different platforms. |
|
In general I agree you can never have too much validation and too much test coverage - except for limited time and resources. In this case though we should enforce a single openssl version per product. Maybe even a single openssl version across all SOF. Why? Simply because we have very limited validation time and resources. @aiChaoSONG did you find this failure in an unsupported openssl version? |
|
It looks like @aiChaoSONG is using openssl version above 3.0. If rimage pass CI in this PR thesofproject/sof#7196 , it means that it using older openssl same as rimage CI. |
|
We need to deprecate support for older ssl versions. Version 3.0 has been out for some time now so should be easily available on all developer OS configurations. |
|
tl;dr: openssl3 reached popular distros about 1 year ago but there is no stable Debian release with openssl 3 yet :-( Ubuntu 22.04 was the first Ubuntu release with openssl3 Fedora apparently upgraded to openssl 3 in Fedora 36 which was released in May 2022 |
|
@softwarecki @marc-hb And tackling different openssl versions is a bit of separate issue. Our PR CI will only use one version at time and a minimum bar is that any submitted code works with that version. If it doesn't, the code will break the CI for all new submitted code. |
Recent changes introduce build error, fix the build error.