Refactor to use changed format metadata to key #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVrachev
changed the title
3 tasks
MVrachev
force-pushed
the
refactor-format-metadata-to-key
branch
from
0f0baa7
to
152068b
Compare
|
I made changes to this pr, but in order to tests those changes a new version of securesyslib should be published adding the changes in the format_metadata_to_key. |
joshuagl
added
the
securesystemslib
MVrachev
force-pushed
the
refactor-format-metadata-to-key
branch
from
152068b
to
e03b098
Compare
MVrachev
changed the title
|
I rebased on the recent changes in the develop branch and the tests should no longer fail, but I don't know why |
|
Hi @MVrachev. With the release of securesystemslib 0.16.0 we are ready to include this change. Could you rebase this on the latest develop branch and when doing so edit setup.py to bump the minimum version of securesystemslib in We should also stop passing |
In commit b7a15fdee7dee899c098b01fe64d604635b2b132 or pr secure-systems-lab/securesystemslib#227 in securesystemslib I change the function arguments of the format_metadata_to_key function in securesystemslib/keys.py to add the opportunity to use custom keyid hash algorithms without chainging the securesystemslib.settings.HASH_ALGORITHMS variable. With this commit, I make use of the above changes in tuf. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
force-pushed
the
refactor-format-metadata-to-key
branch
from
e03b098
to
7a828ea
Compare
|
Rebased upon the latest changes in tuf and bumped securesyslib to 0.16.0 in |
joshuagl
added a commit
to joshuagl/tuf
that referenced
this pull request
Sep 9, 2020
PR theupdateframework#1014 removed uses of keyid_hash_algorithms in favour of using the calculated keyid values from the metadata. A few instances of this removal were unintentionally reintroduced in PR theupdateframework#1016, when changing to explicitly passing a list of hash algorithms rather than changing securesystemslib settings values. This change removes uneccessary uses of keyid_hash_algorithms. Signed-off-by: Joshua Lock <jlock@vmware.com>
3 tasks
MVrachev
pushed a commit
to MVrachev/tuf
that referenced
this pull request
Sep 17, 2020
PR theupdateframework#1014 removed uses of keyid_hash_algorithms in favour of using the calculated keyid values from the metadata. A few instances of this removal were unintentionally reintroduced in PR theupdateframework#1016, when changing to explicitly passing a list of hash algorithms rather than changing securesystemslib settings values. This change removes uneccessary uses of keyid_hash_algorithms. Signed-off-by: Joshua Lock <jlock@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
This pr enables tuf to use changes made in secure-systems-lab/securesystemslib#227
Don't merge before the above pr is merged!
Description of the changes being introduced by the pull request:
Because of issue secure-systems-lab/securesystemslib#227
I had to checkout to the last commit which doesn't had that issue and
make the current changes based on it.
Please verify and check that the pull request fulfills the following
requirements: