Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accidentally introduced uses of keyid_hash_algorithms #1121

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Remove accidentally introduced uses of keyid_hash_algorithms #1121

merged 1 commit into from
Sep 10, 2020

Conversation

joshuagl
Copy link
Member

@joshuagl joshuagl commented Sep 9, 2020

Fixes issue #: N/A

Description of the changes being introduced by the pull request:

PR #1014 removed uses of keyid_hash_algorithms, but a couple of uses were re-introduced in PR #1016. This PR removes uses of keyid_hash_algorithms to match #1014

Please verify and check that the pull request fulfills the following
requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@joshuagl
Remove uses of keyid_hash_algorithms
7c18cbb 
PR theupdateframework#1014 removed uses of keyid_hash_algorithms in favour of using the calculated
keyid values from the metadata. A few instances of this removal were
unintentionally reintroduced in PR theupdateframework#1016, when changing to explicitly passing
a list of hash algorithms rather than changing securesystemslib settings
values.

This change removes uneccessary uses of keyid_hash_algorithms.

Signed-off-by: Joshua Lock <jlock@vmware.com>
@joshuagl joshuagl requested a review from mnm678 September 9, 2020 09:55
@joshuagl
Copy link
Member Author

joshuagl commented Sep 9, 2020

@mnm678 could you take a look at this? I missed this detail when reviewing #1016 and want to make sure we're in-line with the intent of the changes introduced in #1014

@joshuagl joshuagl changed the title Remove accidentally introduced uses of keyid_hash_algorithmsa Remove accidentally introduced uses of keyid_hash_algorithms Sep 9, 2020
@joshuagl joshuagl mentioned this pull request Sep 9, 2020
Merged
3 tasks
@mnm678
Copy link
Contributor

mnm678 commented Sep 9, 2020

@mnm678 could you take a look at this? I missed this detail when reviewing #1016 and want to make sure we're in-line with the intent of the changes introduced in #1014

Yes, this looks good. In a future breaking change it may be worth removing support for the keyid_hash_algorithm field altogether

@joshuagl joshuagl merged commit 37b5d40 into theupdateframework:develop Sep 10, 2020
@joshuagl joshuagl deleted the joshuagl/rm-keyid-hash-algorithms branch September 10, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnm678 mnm678 mnm678 approved these changes

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuagl @mnm678 @trishankatdatadog