Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][BPRT] edi_sale_oca: Backport from v16.0 #23

Open
wants to merge 30 commits into
base: 14.0
Choose a base branch
from

Conversation

thienvh332
Copy link
Owner

No description provided.

@thienvh332 thienvh332 marked this pull request as ready for review June 28, 2024 08:41
@QuocDuong1306
Copy link

Hi a @thienvh332, we should change edi_disable_auto to disable_edi_auto : here, right?

@QuocDuong1306
Copy link

We also should change the version to 14.0.1.0.0, right?
Btw, I think you could add your address to the CONTRIBUTOR.rst to record your effort on this module (optional)

@thienvh332
Copy link
Owner Author

Hello @QuocDuong1306 , I updated it. Could you take a look at this?

Copy link

@QuocDuong1306 QuocDuong1306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thank a Thien

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants