Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][BPRT] EDI sale: port changes from v16 #31

Open
wants to merge 76 commits into
base: 14.0
Choose a base branch
from
Open

Conversation

thienvh332
Copy link
Owner

@thienvh332 thienvh332 commented Aug 9, 2024

This PR introduces several backports and new modules to the edi_sale set of modules in 14.0 branch. This is an attempt to benefit from all the refactoring that was done during migration to 14.0.

  1. edi_sale_endpoint:
  • Added a new module edi_sale_endpoint: A Glue module between edi_sale_oca and edi_endpoint_oca
  • This module is a format-patch from PR 831 on Simone's OCA EDI repository.
  1. edi_sale_oca:
  • Backported this module from version 16 to ensure compatibility with older versions.
  1. edi_sale_ubl_oca:
  • Added a dependency on the edi_exchange_type_auto module.

Context: Previously, edi_sale_ubl_oca depended on edi_sale_oca, which included the edi_exchange_type_auto module. However, edi_exchange_type_auto has now been removed from edi_sale_oca. To ensure that edi_sale_ubl_oca functions as before, we’ve explicitly added edi_exchange_type_auto as a dependency in this module.

  • This is based on the 14-edi-ubl-order-response branch from Camptocamp, a branch that was integrated earlier with several EDI modules and changes specific to our project.
  1. edi_sale_order_import*:
  • Added a deprecation notice for the edi_sale_order_import* modules.
  • This change is also based on the 14-edi-ubl-order-response branch from Camptocamp, a branch that was integrated earlier with several EDI modules and changes specific to our project.
  1. edi_sale_ubl_endpoint_oca:
  • Added edi_sale_ubl_endpoint_oca module to replace edi_sale_order_import_endpoint_oca module.

Context: Since the edi_sale_order_import and edi_sale_order_import_ubl modules are being deprecated, the edi_sale_ubl_endpoint_oca module was created as a replacement to maintain functionality and ensure consistent naming conventions across the new edi_sale modules.

simahawk and others added 30 commits July 1, 2024 11:08
The Form class is just too dumb.
If a field is not there it's broken
and if you pass a view for a main record
you cannot pass any for the x2m fields
which makes it impossible to use for general purpose.
Additionally, avoid recomputing states for all lines
when we know which lines have changed.
Several lines' state make the order not satisfied.
@thienvh332 thienvh332 marked this pull request as ready for review August 9, 2024 07:35
@nilshamerlinck
Copy link

To maintain compatibility with older versions, these changes should be backported.

To maintain compatibility with older versions, these changes have now been backported.

Added a new module edi_sale_endpoint.

purpose?

Added a dependency on the edi_exchange_type_auto module.

why?

14-edi-ubl-order-response branch

what is the context of that branch? probably worth adding link to PR

Added edi_sale_ubl_endpoint_oca module to replace edi_sale_order_import_endpoint_oca module

why?

In general, always consider that the reviewer doesn't know anything about the history of changes.

@nilshamerlinck
Copy link

This PR introduces several changes and new modules within the edi_sale set of modules. All the modules have been migrated to version 16 and have undergone some refactoring. To maintain compatibility with older versions, these changes have now been backported.

This PR introduces several backports and new modules to the edi_sale set of modules in 14.0 branch. This is an attempt to benefit from all the refactoring that was done during migration to 14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants