Implements fix described in https://github.com/knolleary/pubsubclient/issues/832 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the oneliner fix suggested by arjenhiemstra to fix issue knolleary#832 (knolleary#832) on the main PubSubClient github. This solves the issue where the ESP32 would crash if a Shared Attribute or RPC callback is received while we are uploading telemetry.
|
Not required anymore, because #10 should fix any issues with sending data while receiving data. Because it is now seperated into a send and receive buffer. So the sending and receiving never directly interact with each either like it did previously. This pull request can be closed without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the oneliner fix suggested by arjenhiemstra to fix issue knolleary#832 (knolleary#832) on the main PubSubClient github.
This solves the issue where the ESP32 would crash if a Shared Attribute or RPC callback is received while we are uploading telemetry.