turn validate-prescriptions into pre-commit hook #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to keep going even if we encounter an error to get the whole list.
VannTen
force-pushed
the
feat/pre-commit-hook
branch
from
7917c16 to
aa451ff
Compare
- Passing explicit files instead of directories is necessary to work as a pre-commit hook. - Does not exit early on error to report all of them. Since there is several places which validates the prescriptions (voluptous schema + custom codes), we're doing a gross hack by counting the number of ERROR messages logged to get the count of prescriptions errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
closes #2391
needs thoth-station/python#489 + a release to work
This introduces a breaking change
This should yield a new module release