Limit packaging to <22 #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temp fix
harshad16
requested changes
Jan 11, 2023
There was a problem hiding this comment.
we need the same change here as well
Line 13 in 10fd504
so that other modules using thoth-station/python
don't override the packaging version.
|
Can we get rid of requirements.txt and use setuptools-pipfile to avoid
having two files to maintain ?
|
yeah sounds good |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temp fix
Related Issues and Dependencies
thoth-station/adviser#2404
thoth-station/adviser#2405
Context : pypa/packaging#321
This introduces a breaking change
This should yield a new module release
Description
Stop-gap fix. We'll need to adpat to packaging version >21 eventually