-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
aria-labelledby
on tables (#886)
`aria-labelledby` accepts `id`s of other elements which act as an accessible label(s). It's great for providing a label to tables, which are large amounts of content; it helps people understand what the table content actually is. We're currently using `aria-labelledby` on tables in Administrate, pointing to the `id` of the `h1` on index pages. However, this breaks when tables are shown as attribute data on show pages, because the `id` of `page-title` does not exist, and it also is not the proper label for the table (the attribute name is). You can see an example of this here: https://administrate-prototype.herokuapp.com/admin/customers/9849 This PR allows an `id` of an element to be passed into the partial which displays the collection table, so that it can used as the value for the table's `aria-labelledby` attribute.
- Loading branch information
1 parent
155d0c1
commit 7fb4843
Showing
4 changed files
with
11 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters