Fix aria-labelledby on tables
#886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysongach
added
the
views-and-styles
BenMorganIO
approved these changes
May 12, 2017
tysongach
force-pushed
the
tg-table-titles
branch
from
413ba6b to
535fd14
Compare
`aria-labelledby` accepts `id`s of other elements which act as an accessible label(s). It's great for providing a label to tables, which are large amounts of content; it helps people understand what the table content actually is. We're currently using `aria-labelledby` on tables in Administrate, pointing to the `id` of the `h1` on index pages. However, this breaks when tables are shown as attribute data on show pages, because the `id` of `page-title` does not exist, and it also is not the proper label for the table (the attribute name is). You can see an example of this here: https://administrate-prototype.herokuapp.com/admin/customers/9849 This PR allows an `id` of an element to be passed into the partial which displays the collection table, so that it can used as the value for the table's `aria-labelledby` attribute.
tysongach
force-pushed
the
tg-table-titles
branch
from
535fd14 to
b24ba86
Compare
iarie
pushed a commit
to iarie/administrate
that referenced
this pull request
Jun 17, 2017
`aria-labelledby` accepts `id`s of other elements which act as an accessible label(s). It's great for providing a label to tables, which are large amounts of content; it helps people understand what the table content actually is. We're currently using `aria-labelledby` on tables in Administrate, pointing to the `id` of the `h1` on index pages. However, this breaks when tables are shown as attribute data on show pages, because the `id` of `page-title` does not exist, and it also is not the proper label for the table (the attribute name is). You can see an example of this here: https://administrate-prototype.herokuapp.com/admin/customers/9849 This PR allows an `id` of an element to be passed into the partial which displays the collection table, so that it can used as the value for the table's `aria-labelledby` attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-labelledbyacceptsids of other elements which act as anaccessible label(s). It's great for providing a label to tables, which
are large amounts of content; it helps people understand what the
table content actually is.
We're currently using
aria-labelledbyon tables in Administrate,pointing to the
idof theh1on index pages. However, this breakswhen tables are shown as attribute data on show pages, because the
idof
page-titledoes not exist, and it also is not the proper label forthe table (the attribute name is). You can see an example of this here:
https://administrate-prototype.herokuapp.com/admin/customers/9849
This PR allows an
idof an element to be passed into the partialwhich displays the collection table, so that it can used as the value
for the table's
aria-labelledbyattribute.