fix: Add map props in SpotLight.d.ts #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Related three.js PR: mrdoob/three.js#21944, https://threejs.org/examples/#webgl_lights_spotlight. |
joshuaellis
approved these changes
Nov 21, 2022
Contributor
Author
|
oops should I resolve conflict in my side? |
Member
|
please. |
This reverts commit c001b42.
Contributor
Author
|
I closed PR for resolve conflict :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
mrdoob/three.js#24993 (comment)
What
Since SpotLight can have map props, we have to add
mapproperty in SpotLight.d.tsChecklist
master, next goesdev)