Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Clearer wording for Logfiles needed & Clear indication of uptime for Standby Nodes on Dashboard #2669

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix: Clearer wording for Logfiles needed & Clear indication of uptime for Standby Nodes on Dashboard #2669

merged 1 commit into from
Jun 6, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

Description

Enhanced the log message in the 'getNodeAvailability' by displaying the node status instead of hard-coding it as 'down'.

Changes

  • Enhanced the log message in the 'getNodeAvailability' by displaying the node status instead of hard-coding it as 'down'.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft May 9, 2024 08:56
@Mahmoud-Emad
Copy link
Contributor Author

Mahmoud-Emad commented May 9, 2024 •
edited
Loading

I converted this PR to a draft until I ask Mahendara about what is the best case to cover this comment

In the Node Finder looking at my node, it says it has been up less than a day and is in Standby Node. I think that is misleading since a non-technical person might see that and think the node is unreliable. In fact it has been available 24/hours a day for months just in Standby. When I look at my node in the dashboard it says it has been up 3.82%. Technically that is true, but in fact it has been available for 24/hours per day for months, just in Standby.

@Mahmoud-Emad
Copy link
Contributor Author

Update on this PR, Case 1 will be covered

@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review June 6, 2024 11:42
@Mahmoud-Emad Mahmoud-Emad force-pushed the development_clearer_wording_for_node_status branch from 78daa61 to 3cf8e30 Compare June 6, 2024 12:38
@Mahmoud-Emad Mahmoud-Emad merged commit 7b48827 into development Jun 6, 2024
3 checks passed
@Mahmoud-Emad Mahmoud-Emad deleted the development_clearer_wording_for_node_status branch June 6, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mahmoud-Emad @MohamedElmdary @zaelgohary