Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Clearer wording for Logfiles needed & Clear indication of uptime for Standby Nodes on Dashboard #2669

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix: Clearer wording for Logfiles needed & Clear indication of uptime for Standby Nodes on Dashboard #2669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/playground/src/utils/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,25 +85,25 @@ export async function getNodeAvailability(nodeId: number) {
const fakeDataPoint = { timestamp: currentPeriodStartTimestamp, uptime: 0 };
uptimeEvents.unshift(fakeDataPoint);

let downtime = 0;
let time = 0;
for (let i = 0; i < uptimeEvents.length - 1; i++) {
// if uptime decreases with time, then node was down in that time period, so add time period to node downtime
// if uptime decreases with time, then node was down in that time period, so add time period to node time
if (
uptimeEvents[i].uptime > uptimeEvents[i + 1].uptime ||
uptimeEvents[i + 1].uptime < uptimeEvents[i + 1].timestamp - uptimeEvents[i].timestamp
) {
downtime += uptimeEvents[i + 1].timestamp - uptimeEvents[i].timestamp - uptimeEvents[i + 1].uptime;
time += uptimeEvents[i + 1].timestamp - uptimeEvents[i].timestamp - uptimeEvents[i + 1].uptime;
}
}

const elapsedSinceLastUptimeEvent = secondsSinceEpoch - uptimeEvents[uptimeEvents.length - 1].timestamp;
if (elapsedSinceLastUptimeEvent >= UPTIME_EVENTS_INTERVAL) {
downtime += elapsedSinceLastUptimeEvent;
time += elapsedSinceLastUptimeEvent;
}
console.log(
`getNodeAvailability: Node ${nodeId} was down for ${downtime} seconds in the last ${secondsSinceCurrentPeriodStart} seconds.`,
`getNodeAvailability: Node ${nodeId} was down for ${time} seconds in the last ${secondsSinceCurrentPeriodStart} seconds.`,
);
return { downtime: downtime, currentPeriod: secondsSinceCurrentPeriodStart };
return { downtime: time, currentPeriod: secondsSinceCurrentPeriodStart };
}

export async function getFarmUptimePercentage(farm: NodeInterface[]) {
Expand Down
Loading