Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update max name length in solutions #3549

Merged
merged 6 commits into from
Nov 4, 2024
Merged

update max name length in solutions #3549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5814655
update max name length from 50 to 35
amiraabouhadid Oct 23, 2024
79a842e
Merge branch 'development' into dev_name_validation_length
amiraabouhadid Oct 28, 2024
21f33f0
change subdomain name max length
amiraabouhadid Oct 29, 2024
4ecf534
update max name length to 15 in all solutions that require domain
amiraabouhadid Nov 3, 2024
82df2d5
Merge branch 'development' into dev_name_validation_length
amiraabouhadid Nov 3, 2024
e6738a4
change subdomain max length to 35
amiraabouhadid Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grid_client/src/modules/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { IsAlphanumericExpectUnderscore } from "../helpers";
import { Deployment } from "../zos/deployment";
import { ZdbModes } from "../zos/zdb";
import { blockchainType } from "./blockchainInterface";
const NameLength = 50;
const NameLength = 35;
const FarmNameLength = 40;

enum ContractStates {
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/components/caprover_worker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
:value="$props.modelValue.name"
#="{ props }"
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/components/k8s_worker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
validators.minLength('Name minimum length is 2 chars.', 2),
validators.maxLength('Name max length is 50 chars.', 50),
validators.maxLength('Name max length is 35 chars.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/components/manage_gateway_dialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ export default {
validators.isAlphanumeric("Subdomain should consist of letters and numbers only."),
(subdomain: string) => validators.isAlpha("Subdomain must start with an alphabet char.")(subdomain[0]),
validators.minLength("Subdomain must be at least 4 characters.", 4),
(subdomain: string) => validators.maxLength("Subdomain cannot exceed 50 characters.", 50)(subdomain),
(subdomain: string) => validators.maxLength("Subdomain cannot exceed 35 characters.", 35)(subdomain),
];

const portRules = [validators.required("Port is required."), validators.isPort("Please provide a valid port.")];
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/freeflow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.required('Name is required.'),
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
validators.minLength('Name must be at least 4 characters.', 4),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
4 changes: 2 additions & 2 deletions packages/playground/src/weblets/full_vm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down Expand Up @@ -105,7 +105,7 @@
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Disk name minimum length is 2 characters.', 2),
validators.isAlphanumeric('Disk name only accepts alphanumeric characters.'),
validators.maxLength('Disk name maximum length is 50 characters.', 50),
validators.maxLength('Disk name maximum length is 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/jenkins.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
4 changes: 2 additions & 2 deletions packages/playground/src/weblets/micro_vm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down Expand Up @@ -131,7 +131,7 @@
}),
validators.minLength('Disk name minimum length is 2 characters.', 2),
validators.isAlphanumeric('Disk name only accepts alphanumeric characters.'),
validators.maxLength('Disk name maximum length is 50 characters.', 50),
validators.maxLength('Disk name maximum length is 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_algorand.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_casperlabs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_discourse.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
8 changes: 5 additions & 3 deletions packages/playground/src/weblets/tf_domains.vue
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to be 15 here as the name here is the gateway name lets make it 35

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
image

Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<template>
<weblet-layout ref="layout">

<template #title><span><v-icon class="pr-3">mdi-web-box</v-icon></span>Deploy Domains Instance </template>
<template #title
><span><v-icon class="pr-3">mdi-web-box</v-icon></span
>Deploy Domains Instance
</template>

<d-tabs :tabs="[{ title: 'Config', value: 'config' }]">
<template #config>
Expand All @@ -14,7 +16,7 @@
validators.isAlphanumeric('Subdomain should consist of letters and numbers only.'),
subdomain => validators.isAlpha('Subdomain must start with alphabet char.')(subdomain[0]),
validators.minLength('Subdomain must be at least 4 characters.', 4),
subdomain => validators.maxLength('Subdomain cannot exceed 50 characters.', 50)(subdomain),
subdomain => validators.maxLength('Subdomain cannot exceed 35 characters.', 35)(subdomain),
]"
:async-rules="[validateSubdomain]"
#="{ props }"
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_funkwhale.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_jitsi.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
name => validators.isAlpha('Name must start with alphabet char.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_kubernetes.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
validators.minLength('Name minimum length is 2 chars.', 2),
validators.maxLength('Name max length is 50 chars.', 50),
validators.maxLength('Name max length is 35 chars.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_mattermost.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_nextcloud.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_nostr.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_owncloud.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_peertube.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_presearch.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_staticwebsite.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_subsquid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_taiga.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_umbrel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tf_wordpress.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 15 characters.', 15),
]"
#="{ props }"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/src/weblets/tfrobot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
validators.IsAlphanumericExpectUnderscore('Name should consist of letters ,numbers and underscores only.'),
(name: string) => validators.isAlpha('Name must start with an alphabetical character.')(name[0]),
validators.minLength('Name must be at least 2 characters.', 2),
validators.maxLength('Name cannot exceed 50 characters.', 50),
validators.maxLength('Name cannot exceed 35 characters.', 35),
]"
#="{ props }"
>
Expand Down
Loading