Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update max name length in solutions #3549

Merged
merged 6 commits into from
Nov 4, 2024
Merged

update max name length in solutions #3549

merged 6 commits into from
Nov 4, 2024

Conversation

amiraabouhadid
Copy link
Contributor

@amiraabouhadid amiraabouhadid commented Oct 23, 2024 •
edited
Loading

Changes

  • changed max name length in deployment model in client
  • changed max name length in all deployment dashboard validation
  • in solutions that require domain, max name length was changed to 15 chars
  • in all other solutions, max name length was changed to 35 chars

Related Issues

#2364

Tested Scenarios

  • entered a name longer than 35 chars in dashboard deployments

image

@amiraabouhadid amiraabouhadid marked this pull request as ready for review October 23, 2024 08:31
0oM4R
0oM4R reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

is there a reason for gitea to be only 15 char ?

@amiraabouhadid
Copy link
Contributor Author

image

is there a reason for gitea to be only 15 char ?

good question, for node pilot too @zaelgohary ?

@zaelgohary
Copy link
Contributor

is there a reason for gitea to be only 15 char ?

good question, for node pilot too @zaelgohary ?

I'm not sure if node pilot has another restriction rule on its own but you may try to deploy and check if it works.

@amiraabouhadid
Copy link
Contributor Author

amiraabouhadid commented Oct 28, 2024 •
edited
Loading

@0oM4R changing gitea and node pilot name max length to 35 and deploying throws this error

image

image

so won't be changing gitea and node pilot max length from 15 to 35

0oM4R
0oM4R requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to handle gatewaynameModal length, i see it got changed here

it is happening with matermost
Screenshot from 2024-10-29 13-32-50

@amiraabouhadid
Copy link
Contributor Author

@0oM4R good catch, got validation error for more than 36 chars indeed
image
it has been set to 35 char max now

0oM4R
0oM4R reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have to update gatewaynameModel to accept the namelength + length of the domain @AhmedHanafy725 can you please provide numbers here ?

this was already exists but I don't know why it got removed
after manage that please update gitea and node pilot domain names

@amiraabouhadid amiraabouhadid changed the title update max name length from 50 to 35 update max name length in solutions Nov 4, 2024
0oM4R
0oM4R reviewed Nov 4, 2024
View reviewed changes
packages/playground/src/weblets/tf_domains.vue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to be 15 here as the name here is the gateway name lets make it 35

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
image

@amiraabouhadid amiraabouhadid merged commit a080c4d into development Nov 4, 2024
10 checks passed
@amiraabouhadid amiraabouhadid deleted the dev_name_validation_length branch November 4, 2024 10:31
0oM4R added a commit that referenced this pull request Nov 5, 2024
@0oM4R @Marinaa-Emad
@A-Harby @amiraabouhadid @AhmedHanafy725
Development 2.7 update (#3595)
bead750 
* Development selenium add stats page tests 1 (#3313)

* development_selenium_add_stats_page_tests

* development_selenium_add_stats_page_tests_1

* development_selenium_add_stats_page_tests

* remove all whitespace

* remove all whitespace

* remove all whitespace

* remove all whitespace

* remove all whitespace

* remove unwanted cache files and increase timeout duration

* change the network to dev

* bring back config

* spilt test into 2 tests

* fix Codacy issues

* add docstring, comments and improve code

* correct convertation of GB to byte

---------

Co-authored-by: A-Harby <harbya@incubaid.com>

* update max timeout message (#3574)

* refactor: KYC health (#3582)

update the KYC client to parse the status from result key
update kycMonitor to parse the status from result key

* fix domain list error on reload (#3583)

* add no error msg handlinng

* update err handling on reload

* add failedToListGws and erroMessage reset at start of load func

* update max name length in solutions (#3549)

* update max name length from 50 to 35

* change subdomain name max length

* update max name length to 15 in all solutions that require domain

* change subdomain max length to 35

* Fix: add monitoring to grid client dependencies

* Fix: add monitoring to grid client dependencies (#3585)

* Chore: update charts and values version

* v2.6.0-rc3

---------

Co-authored-by: Marinaa-Emad <84817975+Marinaa-Emad@users.noreply.github.com>
Co-authored-by: A-Harby <harbya@incubaid.com>
Co-authored-by: Amira <56790126+amiraabouhadid@users.noreply.github.com>
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amiraabouhadid @zaelgohary @samaradel @0oM4R