fix domain list error on reload #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiraabouhadid
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
AlaaElattar,
0oM4R and
samaradel
as code owners
0oM4R
approved these changes
Nov 4, 2024
samaradel
approved these changes
Nov 4, 2024
0oM4R
added a commit
that referenced
this pull request
Nov 5, 2024
* Development selenium add stats page tests 1 (#3313) * development_selenium_add_stats_page_tests * development_selenium_add_stats_page_tests_1 * development_selenium_add_stats_page_tests * remove all whitespace * remove all whitespace * remove all whitespace * remove all whitespace * remove all whitespace * remove unwanted cache files and increase timeout duration * change the network to dev * bring back config * spilt test into 2 tests * fix Codacy issues * add docstring, comments and improve code * correct convertation of GB to byte --------- Co-authored-by: A-Harby <harbya@incubaid.com> * update max timeout message (#3574) * refactor: KYC health (#3582) update the KYC client to parse the status from result key update kycMonitor to parse the status from result key * fix domain list error on reload (#3583) * add no error msg handlinng * update err handling on reload * add failedToListGws and erroMessage reset at start of load func * update max name length in solutions (#3549) * update max name length from 50 to 35 * change subdomain name max length * update max name length to 15 in all solutions that require domain * change subdomain max length to 35 * Fix: add monitoring to grid client dependencies * Fix: add monitoring to grid client dependencies (#3585) * Chore: update charts and values version * v2.6.0-rc3 --------- Co-authored-by: Marinaa-Emad <84817975+Marinaa-Emad@users.noreply.github.com> Co-authored-by: A-Harby <harbya@incubaid.com> Co-authored-by: Amira <56790126+amiraabouhadid@users.noreply.github.com> Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
#3389
Tested Scenarios
set timeout to 12 seconds to generate failed domains list error
update timeout to window.env.timout, go offline, then back online and press reload, error should be gone
Screenshots/Video attached (needed for UI changes)
