Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor A2C/PPO, change behavior of value normalization #321

Merged
merged 7 commits into from
Mar 25, 2021

Conversation

ChenDRAG
Copy link
Collaborator

Refactor A2C/PPO to make them look consistent. Change behavior of value normalization, etc to be prepared for A2C benchmark.

@ChenDRAG ChenDRAG requested a review from Trinkle23897 March 24, 2021 07:14
@ChenDRAG ChenDRAG self-assigned this Mar 24, 2021
@ChenDRAG
Copy link
Collaborator Author

related to #307

danagi
danagi previously approved these changes Mar 24, 2021
Trinkle23897
Trinkle23897 previously approved these changes Mar 25, 2021
@codecov-io
Copy link

Codecov Report

Merging #321 (4772e71) into master (47c7789) will decrease coverage by 0.02%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   93.97%   93.95%   -0.03%     
==========================================
  Files          51       51              
  Lines        3269     3274       +5     
==========================================
+ Hits         3072     3076       +4     
- Misses        197      198       +1     
Flag Coverage Δ
unittests 93.95% <91.89%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/a2c.py 90.16% <86.95%> (-0.91%) ⬇️
tianshou/policy/modelfree/pg.py 96.00% <100.00%> (ø)
tianshou/policy/modelfree/ppo.py 94.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c7789...4772e71. Read the comment docs.

@Trinkle23897 Trinkle23897 merged commit 3ac67d9 into thu-ml:master Mar 25, 2021
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plans of releasing mujoco benchmark of onpolicy algorithms(VPG, A2C, PPO)
4 participants