Broken on MacOS Ventura

[chaosarium]

Bug description

❯ thumbsup --input ./input --output ./out --log debug

/usr/local/lib/node_modules/thumbsup/node_modules/macos-release/index.js:27
        const [name, version] = nameMap.get(release);
                                ^

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at macosRelease (/usr/local/lib/node_modules/thumbsup/node_modules/macos-release/index.js:27:26)
    at osName (/usr/local/lib/node_modules/thumbsup/node_modules/os-name/index.js:21:18)
    at new Insight (/usr/local/lib/node_modules/thumbsup/node_modules/insight/lib/index.js:37:13)
    at new Analytics (/usr/local/lib/node_modules/thumbsup/bin/analytics.js:11:20)
    at Object.<anonymous> (/usr/local/lib/node_modules/thumbsup/bin/thumbsup.js:28:19)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)

Steps to reproduce

1. Update to MacOS Ventura (13)
2. Attempt to run thumbsup --input ./input --output ./out

Potential fix

In node_modules/thumbsup/node_modules/macos-release/index.js:27, adding the line [22, ['Ventura', '13']], to before [21, ['Monterey', '12']], temporarily fixes the issue

[aellwein]

Had a same issue today.
@rprieto why is this macos-release package needed anyway? It always breaks things up with every major MacOS release cause thumbsup always needs to keep it current.

[rprieto]

Hi, thanks for raising this. Unfortunately macos-release is not a direct dependency, it’s quite deep in the chain.

I see the package itself now supports Ventura, I will try updating all dependencies to see if the latest version is pulled down.

[rprieto]

This dependency is coming from the insight package, which uses an old version of macos-release. insights is used to report optional & anonymous usage metrics (OS version, Gallery size...). I will raise an issue. If this doesn't work I'll have to consider dropping the metrics, although it's been useful to understand what use-cases to focus on.

[aellwein]

@rprieto thank you!

[mischah]

Here is the upstream issue in case someone wants to fix this:
yeoman/insight#83

[rprieto]

For now I have removed usage stats from thumbsup.
We can re-introduce them again if needed in the future.