Apply suggested fixups #1292
Merged
Apply suggested fixups #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hjiangsu
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When integrating the i18n plugin, I also added the following option to VS Code's
settings.jsonfile.This means that any suggested fixups will be applied when a file is saved. I think this is a really nice time-saver. Unfortunately, it means that if any existing files have suggested fixups, they will be fixed every time you save, even if you don't want to include those changes with your current work.
This PR takes care of a few instances that I've been running into a lot. With these fixups applied, there shouldn't be further unwanted changes in these files upon saving.