Fix account page back button behaviour on Android #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
micahmo
approved these changes
Apr 10, 2024
lib/thunder/pages/thunder_page.dart
Outdated
| @@ -221,24 +222,24 @@ class _ThunderState extends State<Thunder> { | |||
| } | |||
|
|
|||
| // If the incoming link is a custom URL, replace it back with https:// | |||
| String _link = link?.replaceAll('thunder://', 'https://') ?? ""; | |||
| String originalLink = link?.replaceAll('thunder://', 'https://') ?? ""; | |||
There was a problem hiding this comment.
Oh I just fixed this in #1292! 😆
…k-button-account-page
iparks99
pushed a commit
to iparks99/thunder
that referenced
this pull request
Apr 10, 2024
iparks99
pushed a commit
to iparks99/thunder
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where the Account page back button handler and the main Thunder page back button handlers were triggering at the same time.
We can prevent this by using
stopDefaultButtonEventparameter from the BackButtonInterceptor callback function. See https://pub.dev/packages/back_button_interceptor#in-more-detail for more details on how this parameter works.Issue Being Fixed
Relates to #1269
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabels where applicable for accessibility?