-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust language selector styling #1316
Conversation
… feature/language-selector-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks pretty slick! The only feedback I might have is to use a right-facing chevron. On the web, the down arrow implies a literal dropdown, but we're showing a modal. I think we use the right chevron in other places like the account/community selector to imply a modal popup of some sort. Thoughts?
I stylistically prefer the down one, but I agree that since it won't actually be a drop-down in our case that it makes less sense here. Either way I think this is great! Side question: If the language name is long enough/the font size is big enough, does it interact weirdly with the NSFW toggle? |
One more tiny note: is it possible for the inkwell to only be as wide as the text? Right now it takes up the entire available width. |
… feature/language-selector-refactor
Pull Request Description
This PR is a follow up to some of the discussions from #1165. In particular:
@micahmo @machinaeZER0 let me know your thoughts on the style change!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?