Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust language selector styling #1316

Merged
merged 5 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 1 addition & 76 deletions lib/comment/view/create_comment_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import 'dart:convert';
import 'package:flutter/material.dart';

// Package imports
import 'package:collection/collection.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:flutter_keyboard_visibility/flutter_keyboard_visibility.dart';
Expand All @@ -17,14 +16,14 @@ import 'package:shared_preferences/shared_preferences.dart';
// Project imports
import 'package:thunder/comment/cubit/create_comment_cubit.dart';
import 'package:thunder/community/utils/post_card_action_helpers.dart';
import 'package:thunder/core/auth/bloc/auth_bloc.dart';
import 'package:thunder/core/enums/local_settings.dart';
import 'package:thunder/core/models/post_view_media.dart';
import 'package:thunder/core/singletons/preferences.dart';
import 'package:thunder/post/widgets/post_view.dart';
import 'package:thunder/shared/comment_content.dart';
import 'package:thunder/shared/common_markdown_body.dart';
import 'package:thunder/shared/input_dialogs.dart';
import 'package:thunder/shared/language_selector.dart';
import 'package:thunder/shared/snackbar.dart';
import 'package:thunder/user/widgets/user_indicator.dart';
import 'package:thunder/utils/instance.dart';
Expand Down Expand Up @@ -475,80 +474,6 @@ class _CreateCommentPageState extends State<CreateCommentPage> {
}
}

/// Creates a widget which displays a preview of a pre-selected language, with the ability to change the selected language
///
/// Passing in [languageId] will set the initial state of the widget to display that given language.
/// A callback function [onLanguageSelected] will be triggered whenever a new language is selected from the dropdown.
class LanguageSelector extends StatefulWidget {
const LanguageSelector({
super.key,
required this.languageId,
required this.onLanguageSelected,
});

/// The initial language id to be passed in
final int? languageId;

/// A callback function to trigger whenever a language is selected from the dropdown
final Function(Language?) onLanguageSelected;

@override
State<LanguageSelector> createState() => _LanguageSelectorState();
}

class _LanguageSelectorState extends State<LanguageSelector> {
late int? _languageId;
late Language? _language;

@override
void initState() {
super.initState();
_languageId = widget.languageId;

// Determine the language from the languageId
List<Language> languages = context.read<AuthBloc>().state.getSiteResponse?.allLanguages ?? [];
_language = languages.firstWhereOrNull((Language language) => language.id == _languageId);
}

@override
Widget build(BuildContext context) {
final l10n = AppLocalizations.of(context)!;
final theme = Theme.of(context);

return Transform.translate(
offset: const Offset(-8, 0),
child: InkWell(
onTap: () {
showLanguageInputDialog(
context,
title: l10n.language,
onLanguageSelected: (language) {
if (language.id == -1) {
setState(() => _languageId = _language = null);
widget.onLanguageSelected(null);
} else {
setState(() {
_languageId = language.id;
_language = language;
});
widget.onLanguageSelected(language);
}
},
);
},
borderRadius: const BorderRadius.all(Radius.circular(50)),
child: Padding(
padding: const EdgeInsets.only(left: 8, top: 12, bottom: 12),
child: Text(
'${l10n.language}: ${_language?.name ?? l10n.selectLanguage}',
style: theme.textTheme.titleSmall?.copyWith(fontWeight: FontWeight.w600),
),
),
),
);
}
}

class DraftComment {
String? text;
bool saveAsDraft = true;
Expand Down
88 changes: 9 additions & 79 deletions lib/community/pages/create_post_page.dart
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
// Dart imports
import 'dart:async';
import 'dart:convert';
import 'dart:io';

import 'package:collection/collection.dart';
// Flutter imports
import 'package:flutter/material.dart';

// Package imports
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:flutter_keyboard_visibility/flutter_keyboard_visibility.dart';
import 'package:flutter_typeahead/flutter_typeahead.dart';
import 'package:lemmy_api_client/v3.dart';
import 'package:link_preview_generator/link_preview_generator.dart';

import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:markdown_editor/markdown_editor.dart';
import 'package:shared_preferences/shared_preferences.dart';

// Project imports
import 'package:thunder/account/models/account.dart';
import 'package:thunder/community/bloc/image_bloc.dart';
import 'package:thunder/community/utils/post_card_action_helpers.dart';
Expand All @@ -25,18 +28,19 @@ import 'package:thunder/core/models/post_view_media.dart';
import 'package:thunder/core/singletons/lemmy_client.dart';
import 'package:thunder/core/singletons/preferences.dart';
import 'package:thunder/post/cubit/create_post_cubit.dart';
import 'package:thunder/shared/common_markdown_body.dart';
import 'package:thunder/shared/avatars/community_avatar.dart';
import 'package:thunder/shared/common_markdown_body.dart';
import 'package:thunder/shared/cross_posts.dart';
import 'package:thunder/shared/full_name_widgets.dart';
import 'package:thunder/shared/input_dialogs.dart';
import 'package:thunder/shared/language_selector.dart';
import 'package:thunder/shared/link_preview_card.dart';
import 'package:thunder/shared/snackbar.dart';
import 'package:thunder/user/utils/restore_user.dart';
import 'package:thunder/user/widgets/user_selector.dart';
import 'package:thunder/utils/debounce.dart';
import 'package:thunder/utils/media/image.dart';
import 'package:thunder/utils/instance.dart';
import 'package:thunder/utils/media/image.dart';

class CreatePostPage extends StatefulWidget {
final int? communityId;
Expand Down Expand Up @@ -656,80 +660,6 @@ class _CreatePostPageState extends State<CreatePostPage> {
}
}

/// Creates a widget which displays a preview of a pre-selected language, with the ability to change the selected language
///
/// Passing in [languageId] will set the initial state of the widget to display that given language.
/// A callback function [onLanguageSelected] will be triggered whenever a new language is selected from the dropdown.
class LanguageSelector extends StatefulWidget {
const LanguageSelector({
super.key,
required this.languageId,
required this.onLanguageSelected,
});

/// The initial language id to be passed in
final int? languageId;

/// A callback function to trigger whenever a language is selected from the dropdown
final Function(Language?) onLanguageSelected;

@override
State<LanguageSelector> createState() => _LanguageSelectorState();
}

class _LanguageSelectorState extends State<LanguageSelector> {
late int? _languageId;
late Language? _language;

@override
void initState() {
super.initState();
_languageId = widget.languageId;

// Determine the language from the languageId
List<Language> languages = context.read<AuthBloc>().state.getSiteResponse?.allLanguages ?? [];
_language = languages.firstWhereOrNull((Language language) => language.id == _languageId);
}

@override
Widget build(BuildContext context) {
final l10n = AppLocalizations.of(context)!;
final theme = Theme.of(context);

return Transform.translate(
offset: const Offset(-8, 0),
child: InkWell(
onTap: () {
showLanguageInputDialog(
context,
title: l10n.language,
onLanguageSelected: (language) {
if (language.id == -1) {
setState(() => _languageId = _language = null);
widget.onLanguageSelected(null);
} else {
setState(() {
_languageId = language.id;
_language = language;
});
widget.onLanguageSelected(language);
}
},
);
},
borderRadius: const BorderRadius.all(Radius.circular(50)),
child: Padding(
padding: const EdgeInsets.only(left: 8, top: 12, bottom: 12),
child: Text(
'${l10n.language}: ${_language?.name ?? l10n.selectLanguage}',
style: theme.textTheme.titleSmall?.copyWith(fontWeight: FontWeight.w600),
),
),
),
);
}
}

/// Creates a widget which displays a preview of a pre-selected community, with the ability to change the selected community
///
/// Passing in either [communityId] or [communityView] will set the initial state of the widget to display that given community.
Expand Down
2 changes: 1 addition & 1 deletion lib/l10n/app_en.arb
Original file line number Diff line number Diff line change
Expand Up @@ -1437,7 +1437,7 @@
"@selectCommunity": {},
"selectFeedType": "Select Feed Type",
"@selectFeedType": {},
"selectLanguage": "Select language",
"selectLanguage": "Select Language",
"@selectLanguage": {
"description": "The prompt to select a language in the post creation page"
},
Expand Down
97 changes: 97 additions & 0 deletions lib/shared/language_selector.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
// Flutter imports
import 'package:flutter/material.dart';

// Package imports
import 'package:collection/collection.dart';
import 'package:flutter_bloc/flutter_bloc.dart';
import 'package:flutter_gen/gen_l10n/app_localizations.dart';
import 'package:lemmy_api_client/v3.dart';

// Project imports
import 'package:thunder/core/auth/bloc/auth_bloc.dart';
import 'package:thunder/shared/input_dialogs.dart';

/// Creates a widget which displays a preview of a pre-selected language, with the ability to change the selected language
///
/// Passing in [languageId] will set the initial state of the widget to display that given language.
/// A callback function [onLanguageSelected] will be triggered whenever a new language is selected from the dropdown.
class LanguageSelector extends StatefulWidget {
const LanguageSelector({
super.key,
required this.languageId,
required this.onLanguageSelected,
});

/// The initial language id to be passed in
final int? languageId;

/// A callback function to trigger whenever a language is selected from the dropdown
final Function(Language?) onLanguageSelected;

@override
State<LanguageSelector> createState() => _LanguageSelectorState();
}

class _LanguageSelectorState extends State<LanguageSelector> {
late int? _languageId;
late Language? _language;

@override
void initState() {
super.initState();
_languageId = widget.languageId;

// Determine the language from the languageId
List<Language> languages = context.read<AuthBloc>().state.getSiteResponse?.allLanguages ?? [];
_language = languages.firstWhereOrNull((Language language) => language.id == _languageId);
}

@override
Widget build(BuildContext context) {
final l10n = AppLocalizations.of(context)!;
final theme = Theme.of(context);

return Transform.translate(
offset: const Offset(-8, 0),
child: InkWell(
onTap: () {
showLanguageInputDialog(
context,
title: l10n.language,
onLanguageSelected: (language) {
if (language.id == -1) {
setState(() => _languageId = _language = null);
widget.onLanguageSelected(null);
} else {
setState(() {
_languageId = language.id;
_language = language;
});
widget.onLanguageSelected(language);
}
},
);
},
borderRadius: const BorderRadius.all(Radius.circular(50)),
child: Padding(
padding: const EdgeInsets.only(left: 8, top: 12, bottom: 12),
child: Text.rich(
TextSpan(
children: <InlineSpan>[
TextSpan(text: _language != null ? '${l10n.language}: ${_language?.name}' : l10n.selectLanguage),
const WidgetSpan(
alignment: PlaceholderAlignment.middle,
child: Padding(
padding: EdgeInsets.symmetric(horizontal: 4.0),
child: Icon(Icons.expand_more_rounded),
),
),
],
style: theme.textTheme.titleSmall?.copyWith(fontWeight: FontWeight.w600),
),
),
),
),
);
}
}
Loading