Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManageabilityPkg: Add TransportLib instance for IPMI Serial #240

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ManageabilityPkg: Add TransportLib instance for IPMI Serial #240

wants to merge 3 commits into from
+1,195 −6

Conversation

gtossk2
Copy link

@gtossk2 gtossk2 commented Nov 7, 2024

This adds ManageabilityTransportSerialLib instance following the manageability transport framework to support IPMI Serial protocol.

@gtossk2 gtossk2 requested a review from changab as a code owner November 7, 2024 17:41
@changab
Copy link
Member

changab commented Nov 7, 2024

Hi @gtossk2, thanks for this contribution. Lets split this commit into three first. It would give us a clear picture of introducing the serial port interface to edk2 manageability package.

  1. Introduce the new definitions for the serial transport interface. That includes the newly added definitions in the C header file and ManageabilityPkg.dec such as the PCD.
  2. We can introduce the new manageability help library for the serial protocol, and add it in the DSC file.
  3. The last commit would be adopting the serial protocol in IPMI driver.
    Could you please help to update this PR? Thanks!

@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from 17064b9 to d94794a Compare November 7, 2024 21:38
@gtossk2
Copy link
Author

gtossk2 commented Nov 7, 2024

Hi @changab Thanks for the suggestion. I have split the commits into three. Please kindly let me know if it is what you expected. Thanks!

@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from d94794a to 028a2a0 Compare November 8, 2024 15:44
changab
changab reviewed Nov 18, 2024
View reviewed changes
...nageabilityPkg/Library/ManageabilityTransportSerialLib/Common/ManageabilityTransportSerial.h Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
Features/ManageabilityPkg/Library/ManageabilityTransportSerialLib/Common/SerialCommon.c Outdated Show resolved Hide resolved
@gtossk2 gtossk2 mentioned this pull request Nov 21, 2024
Open
@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from 028a2a0 to 736fd16 Compare November 21, 2024 01:09
@gtossk2 gtossk2 requested a review from changab November 21, 2024 01:16
@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from 736fd16 to 387ab12 Compare November 21, 2024 22:16
changab
changab reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@changab changab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtossk2 , please address @abdattar 's commnets.

Thanks

@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from 387ab12 to aa14915 Compare November 22, 2024 20:33
@gtossk2
Copy link
Author

gtossk2 commented Nov 22, 2024

@abdattar Many thanks for the review. I have updated per your comments.

@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from aa14915 to 1b35f66 Compare November 25, 2024 16:24
@abdattar
Copy link
Contributor

code changes looks good to me.
Please address the single comment mentioned in this review.

@gtossk2
ManageabilityPkg: Add serial transport interface
f90ba29 
ManageabilityTransportSerialLib instance following the manageability
transport framework to support IPMI Serial protocol. Data structure
refer to Figure 14, IPMI 2.0.

Signed-off-by: John Chung <john.chung@arm.com>
@gtossk2
ManageabilityPkg: Add serial protocol in manageability help library
462aaec 
This introduces ManageabilityTransportSerial in manageability help
library.

Signed-off-by: John Chung <john.chung@arm.com>
@gtossk2
ManageabilityPkg: Add serial protocol in IPMI driver
4c443b1 
This introduces serial protocol in IPMI driver.

Signed-off-by: John Chung <john.chung@arm.com>
@gtossk2 gtossk2 force-pushed the ManageabilityTransportSerialLib branch from 1b35f66 to 4c443b1 Compare November 26, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@changab changab changab left review comments

@abdattar abdattar abdattar approved these changes

Assignees

@gtossk2 gtossk2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gtossk2 @changab @abdattar